Re: [Qemu-devel] [PATCH v6] hw/acpi: extract acpi_add_rom_blob()

2019-05-29 Thread Wei Yang
On Tue, May 28, 2019 at 11:01:32PM -0400, Michael S. Tsirkin wrote: >On Tue, Mar 26, 2019 at 10:43:20AM +0800, Wei Yang wrote: >> arm and i386 has almost the same function acpi_add_rom_blob(), except >> giving different FWCfgCallback function. >> >> This patch moves acpi_add_rom_blob() to utils.c

Re: [Qemu-devel] [PATCH v6] hw/acpi: extract acpi_add_rom_blob()

2019-05-28 Thread Michael S. Tsirkin
On Tue, Mar 26, 2019 at 10:43:20AM +0800, Wei Yang wrote: > arm and i386 has almost the same function acpi_add_rom_blob(), except > giving different FWCfgCallback function. > > This patch moves acpi_add_rom_blob() to utils.c by passing > FWCfgCallback to it. > > Signed-off-by: Wei Yang > Reviewe

Re: [Qemu-devel] [PATCH v6] hw/acpi: extract acpi_add_rom_blob()

2019-05-27 Thread Wei Yang
On Mon, May 27, 2019 at 10:41:57AM -0400, Michael S. Tsirkin wrote: >On Mon, May 27, 2019 at 10:34:23AM +0800, Wei Yang wrote: >> On Tue, Mar 26, 2019 at 10:43:20AM +0800, Wei Yang wrote: >> >arm and i386 has almost the same function acpi_add_rom_blob(), except >> >giving different FWCfgCallback fu

Re: [Qemu-devel] [PATCH v6] hw/acpi: extract acpi_add_rom_blob()

2019-05-27 Thread Michael S. Tsirkin
On Mon, May 27, 2019 at 10:34:23AM +0800, Wei Yang wrote: > On Tue, Mar 26, 2019 at 10:43:20AM +0800, Wei Yang wrote: > >arm and i386 has almost the same function acpi_add_rom_blob(), except > >giving different FWCfgCallback function. > > > >This patch moves acpi_add_rom_blob() to utils.c by passin

Re: [Qemu-devel] [PATCH v6] hw/acpi: extract acpi_add_rom_blob()

2019-05-26 Thread Wei Yang
On Tue, Mar 26, 2019 at 10:43:20AM +0800, Wei Yang wrote: >arm and i386 has almost the same function acpi_add_rom_blob(), except >giving different FWCfgCallback function. > >This patch moves acpi_add_rom_blob() to utils.c by passing >FWCfgCallback to it. > >Signed-off-by: Wei Yang >Reviewed-by: Ig

Re: [Qemu-devel] [PATCH v6] hw/acpi: extract acpi_add_rom_blob()

2019-05-14 Thread Wei Yang
On Tue, Mar 26, 2019 at 10:43:20AM +0800, Wei Yang wrote: >arm and i386 has almost the same function acpi_add_rom_blob(), except >giving different FWCfgCallback function. > >This patch moves acpi_add_rom_blob() to utils.c by passing >FWCfgCallback to it. > >Signed-off-by: Wei Yang >Reviewed-by: Ig

[Qemu-devel] [PATCH v6] hw/acpi: extract acpi_add_rom_blob()

2019-03-25 Thread Wei Yang
arm and i386 has almost the same function acpi_add_rom_blob(), except giving different FWCfgCallback function. This patch moves acpi_add_rom_blob() to utils.c by passing FWCfgCallback to it. Signed-off-by: Wei Yang Reviewed-by: Igor Mammedov --- v6: * change author from Igor to Michael v5: