Re: [Qemu-devel] [PATCH v6 01/18] build-sys: define QEMU_VERSION_{MAJOR, MINOR, MICRO}

2016-09-13 Thread Eric Blake
On 09/13/2016 02:33 AM, Markus Armbruster wrote: >>> info->qemu = g_new0(VersionTriple, 1); >>> -err = qemu_strtoll(version, , 10, >qemu->major); >>> -assert(err == 0); >>> -tmp++; >>> - >> >> The old code silently ignores any garbage after the third integer (it >> populates ,

Re: [Qemu-devel] [PATCH v6 01/18] build-sys: define QEMU_VERSION_{MAJOR, MINOR, MICRO}

2016-09-13 Thread Markus Armbruster
Eric Blake writes: > On 09/12/2016 04:18 AM, Marc-André Lureau wrote: >> There are better chances to find what went wrong at build time than a >> later assert in qmp_query_version >> >> Signed-off-by: Marc-André Lureau >> --- >> qmp.c

Re: [Qemu-devel] [PATCH v6 01/18] build-sys: define QEMU_VERSION_{MAJOR, MINOR, MICRO}

2016-09-12 Thread Eric Blake
On 09/12/2016 04:18 AM, Marc-André Lureau wrote: > There are better chances to find what went wrong at build time than a > later assert in qmp_query_version > > Signed-off-by: Marc-André Lureau > --- > qmp.c | 16 +++- >

[Qemu-devel] [PATCH v6 01/18] build-sys: define QEMU_VERSION_{MAJOR, MINOR, MICRO}

2016-09-12 Thread Marc-André Lureau
There are better chances to find what went wrong at build time than a later assert in qmp_query_version Signed-off-by: Marc-André Lureau --- qmp.c | 16 +++- scripts/create_config | 6 ++ 2 files changed, 9 insertions(+), 13