Re: [Qemu-devel] [PATCH v6 3/4] kvm: add kvm_support_device() helper function

2016-03-23 Thread Peter Xu
On Wed, Mar 23, 2016 at 06:03:32PM +0300, Sergey Fedorov wrote: > Yes, but kvm_create_device() returns a file descriptor whereas this > function is predicative. Personally, I like the convention described in > chapter 16 of Linux kernel coding style [1]: > > If the name of a function is an

Re: [Qemu-devel] [PATCH v6 3/4] kvm: add kvm_support_device() helper function

2016-03-23 Thread Peter Xu
On Wed, Mar 23, 2016 at 03:28:28PM +0300, Sergey Fedorov wrote: > On 23/03/16 08:32, Peter Xu wrote: > > diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > > index 6695fa7..8738fa1 100644 > > --- a/include/sysemu/kvm.h > > +++ b/include/sysemu/kvm.h > > @@ -306,6 +306,15 @@ void

Re: [Qemu-devel] [PATCH v6 3/4] kvm: add kvm_support_device() helper function

2016-03-23 Thread Sergey Fedorov
On 23/03/16 17:56, Peter Xu wrote: > On Wed, Mar 23, 2016 at 03:28:28PM +0300, Sergey Fedorov wrote: >> On 23/03/16 08:32, Peter Xu wrote: >>> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h >>> index 6695fa7..8738fa1 100644 >>> --- a/include/sysemu/kvm.h >>> +++ b/include/sysemu/kvm.h

Re: [Qemu-devel] [PATCH v6 3/4] kvm: add kvm_support_device() helper function

2016-03-23 Thread Sergey Fedorov
On 23/03/16 08:32, Peter Xu wrote: > diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > index 6695fa7..8738fa1 100644 > --- a/include/sysemu/kvm.h > +++ b/include/sysemu/kvm.h > @@ -306,6 +306,15 @@ void kvm_device_access(int fd, int group, uint64_t attr, > */ > int

[Qemu-devel] [PATCH v6 3/4] kvm: add kvm_support_device() helper function

2016-03-22 Thread Peter Xu
This can be used when probing whether KVM support specific device. Here, a raw vmfd is used. Signed-off-by: Peter Xu --- include/sysemu/kvm.h | 9 + kvm-all.c| 15 +++ 2 files changed, 24 insertions(+) diff --git a/include/sysemu/kvm.h