Re: [Qemu-devel] [PATCH v7 00/10] Convert msix_init() to error

2017-01-11 Thread Cao jin
On 01/10/2017 05:45 AM, Michael S. Tsirkin wrote: > On Mon, Nov 14, 2016 at 03:25:30PM +0800, Cao jin wrote: >> v7 changelog: >> 1. fix the segfaut bug in patch 2. So drop the all the R-b of it, >>please take a look, there is detailed description in the patch. >> 2. add the R-b from Hannes

Re: [Qemu-devel] [PATCH v7 00/10] Convert msix_init() to error

2017-01-10 Thread Paolo Bonzini
On 10/01/2017 17:19, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: >> Generally this patchset is at v7. It brings a very limited benefit to >> the project. It better be perfect otherwise I don't see why bother. > > We obviously disagree on the benefit. Before this

Re: [Qemu-devel] [PATCH v7 00/10] Convert msix_init() to error

2017-01-10 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Tue, Jan 10, 2017 at 11:06:08AM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > On Mon, Nov 14, 2016 at 03:25:30PM +0800, Cao jin wrote: >> >> v7 changelog: >> >> 1. fix the segfaut bug in patch 2. So

Re: [Qemu-devel] [PATCH v7 00/10] Convert msix_init() to error

2017-01-10 Thread Paolo Bonzini
On 10/01/2017 15:38, Michael S. Tsirkin wrote: > On Tue, Jan 10, 2017 at 11:06:08AM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >>> On Mon, Nov 14, 2016 at 03:25:30PM +0800, Cao jin wrote: v7 changelog: 1. fix the segfaut bug in patch 2. So drop

Re: [Qemu-devel] [PATCH v7 00/10] Convert msix_init() to error

2017-01-10 Thread Michael S. Tsirkin
On Tue, Jan 10, 2017 at 11:06:08AM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Mon, Nov 14, 2016 at 03:25:30PM +0800, Cao jin wrote: > >> v7 changelog: > >> 1. fix the segfaut bug in patch 2. So drop the all the R-b of it, > >>please take a look,

Re: [Qemu-devel] [PATCH v7 00/10] Convert msix_init() to error

2017-01-10 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Mon, Nov 14, 2016 at 03:25:30PM +0800, Cao jin wrote: >> v7 changelog: >> 1. fix the segfaut bug in patch 2. So drop the all the R-b of it, >>please take a look, there is detailed description in the patch. >> 2. add the R-b from Hannes

Re: [Qemu-devel] [PATCH v7 00/10] Convert msix_init() to error

2017-01-09 Thread Michael S. Tsirkin
On Mon, Nov 14, 2016 at 03:25:30PM +0800, Cao jin wrote: > v7 changelog: > 1. fix the segfaut bug in patch 2. So drop the all the R-b of it, >please take a look, there is detailed description in the patch. > 2. add the R-b from Hannes Reinecke > > Test: > 1. make check: pass > 2. After

Re: [Qemu-devel] [PATCH v7 00/10] Convert msix_init() to error

2016-12-21 Thread Marcel Apfelbaum
On 12/21/2016 08:16 AM, Cao jin wrote: ping Misses the Acked-by: Marcel Apfelbaum from V6, if it helps. Thanks, Marcel On 11/14/2016 03:25 PM, Cao jin wrote: v7 changelog: 1. fix the segfaut bug in patch 2. So drop the all the R-b of it, please take a look, there

Re: [Qemu-devel] [PATCH v7 00/10] Convert msix_init() to error

2016-12-20 Thread Cao jin
ping On 11/14/2016 03:25 PM, Cao jin wrote: > v7 changelog: > 1. fix the segfaut bug in patch 2. So drop the all the R-b of it, >please take a look, there is detailed description in the patch. > 2. add the R-b from Hannes Reinecke > > Test: > 1. make check: pass > 2. After applied all the

Re: [Qemu-devel] [PATCH v7 00/10] Convert msix_init() to error

2016-11-14 Thread Michael S. Tsirkin
On Mon, Nov 14, 2016 at 03:25:30PM +0800, Cao jin wrote: > v7 changelog: > 1. fix the segfaut bug in patch 2. So drop the all the R-b of it, >please take a look, there is detailed description in the patch. > 2. add the R-b from Hannes Reinecke Pls remember to ping after release. > Test: > 1.

[Qemu-devel] [PATCH v7 00/10] Convert msix_init() to error

2016-11-13 Thread Cao jin
v7 changelog: 1. fix the segfaut bug in patch 2. So drop the all the R-b of it, please take a look, there is detailed description in the patch. 2. add the R-b from Hannes Reinecke Test: 1. make check: pass 2. After applied all the patch, command line test for all the affected devices, just