Re: [Qemu-devel] [PATCH v7 00/15] Add param Error ** for msi_init()

2016-06-10 Thread Cao jin
On 06/09/2016 11:58 PM, Markus Armbruster wrote: I had only minor stylistic remarks this time. However, the series needs a rebase already. If the conflict resolution is trivial, you may add my Yes, it is trivial. just two file name changed in commit 605d52e62: -#include "vmxnet_tx_pkt.h"

Re: [Qemu-devel] [PATCH v7 00/15] Add param Error ** for msi_init()

2016-06-09 Thread Markus Armbruster
I had only minor stylistic remarks this time. However, the series needs a rebase already. If the conflict resolution is trivial, you may add my Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v7 00/15] Add param Error ** for msi_init()

2016-06-08 Thread Cao jin
ping~ On 06/06/2016 04:00 PM, Cao jin wrote: v7 changelog: 1. 4 new patches, patch 11, 13, 14, 15. previous patch 11 numbered 12 now. 2. patch 2: remove comment of "errp", add it in patch 12 3. patch 4: fix commit message as sugguestion 4. replace all "msi == ON_OFF_AUTO_ON || msi ==

[Qemu-devel] [PATCH v7 00/15] Add param Error ** for msi_init()

2016-06-06 Thread Cao jin
v7 changelog: 1. 4 new patches, patch 11, 13, 14, 15. previous patch 11 numbered 12 now. 2. patch 2: remove comment of "errp", add it in patch 12 3. patch 4: fix commit message as sugguestion 4. replace all "msi == ON_OFF_AUTO_ON || msi == ON_OFF_AUTO_AUTO" to "msi != ON_OFF_AUTO_OFF", before