Re: [Qemu-devel] [PATCH v7 07/35] util: introduce qemu_file_get_page_size()

2015-11-09 Thread Eduardo Habkost
On Mon, Nov 09, 2015 at 12:36:36PM +0800, Xiao Guangrong wrote: > On 11/06/2015 11:36 PM, Eduardo Habkost wrote: > >On Mon, Nov 02, 2015 at 05:13:09PM +0800, Xiao Guangrong wrote: > >>There are three places use the some logic to get the page size on > >>the file path or file fd > >> > >>Windows

Re: [Qemu-devel] [PATCH v7 07/35] util: introduce qemu_file_get_page_size()

2015-11-08 Thread Xiao Guangrong
On 11/06/2015 11:36 PM, Eduardo Habkost wrote: On Mon, Nov 02, 2015 at 05:13:09PM +0800, Xiao Guangrong wrote: There are three places use the some logic to get the page size on the file path or file fd Windows did not support file hugepage, so it will return normal page for this case. And

Re: [Qemu-devel] [PATCH v7 07/35] util: introduce qemu_file_get_page_size()

2015-11-06 Thread Eduardo Habkost
On Mon, Nov 02, 2015 at 05:13:09PM +0800, Xiao Guangrong wrote: > There are three places use the some logic to get the page size on > the file path or file fd > > Windows did not support file hugepage, so it will return normal page > for this case. And this interface has not been used on windows

Re: [Qemu-devel] [PATCH v7 07/35] util: introduce qemu_file_get_page_size()

2015-11-02 Thread Vladimir Sementsov-Ogievskiy
On 02.11.2015 12:13, Xiao Guangrong wrote: There are three places use the some logic to get the page size on the file path or file fd Windows did not support file hugepage, so it will return normal page for this case. And this interface has not been used on windows so far This patch

[Qemu-devel] [PATCH v7 07/35] util: introduce qemu_file_get_page_size()

2015-11-02 Thread Xiao Guangrong
There are three places use the some logic to get the page size on the file path or file fd Windows did not support file hugepage, so it will return normal page for this case. And this interface has not been used on windows so far This patch introduces qemu_file_get_page_size() to unify the code