Re: [Qemu-devel] [PATCH v7 3/4] monitor: more comments on lock-free fleids/funcs

2018-05-28 Thread Peter Xu
On Thu, May 24, 2018 at 01:16:11PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Thu, May 24, 2018 at 10:41:09AM +0200, Markus Armbruster wrote: > >> Regarding the subject: what are "fleids"? > > > > Ouch. :( I meant the word "fields". > > Can touch that up in

Re: [Qemu-devel] [PATCH v7 3/4] monitor: more comments on lock-free fleids/funcs

2018-05-24 Thread Markus Armbruster
Peter Xu writes: > On Thu, May 24, 2018 at 10:41:09AM +0200, Markus Armbruster wrote: >> Regarding the subject: what are "fleids"? > > Ouch. :( I meant the word "fields". Can touch that up in my tree. >> Peter Xu writes: >> >> > Add some explicit comment

Re: [Qemu-devel] [PATCH v7 3/4] monitor: more comments on lock-free fleids/funcs

2018-05-24 Thread Peter Xu
On Thu, May 24, 2018 at 10:41:09AM +0200, Markus Armbruster wrote: > Regarding the subject: what are "fleids"? Ouch. :( I meant the word "fields". > > Peter Xu writes: > > > Add some explicit comment for both Readline and cpu_set/cpu_get helpers > > that they do not need

Re: [Qemu-devel] [PATCH v7 3/4] monitor: more comments on lock-free fleids/funcs

2018-05-24 Thread Peter Xu
On Thu, May 24, 2018 at 09:08:04AM +0100, Stefan Hajnoczi wrote: > On Thu, May 24, 2018 at 12:39:51PM +0800, Peter Xu wrote: > > Add some explicit comment for both Readline and cpu_set/cpu_get helpers > > that they do not need the mon_lock protection. > > > > Signed-off-by: Peter Xu

Re: [Qemu-devel] [PATCH v7 3/4] monitor: more comments on lock-free fleids/funcs

2018-05-24 Thread Markus Armbruster
Regarding the subject: what are "fleids"? Peter Xu writes: > Add some explicit comment for both Readline and cpu_set/cpu_get helpers > that they do not need the mon_lock protection. > > Signed-off-by: Peter Xu > --- > monitor.c | 12 +++- > 1 file

Re: [Qemu-devel] [PATCH v7 3/4] monitor: more comments on lock-free fleids/funcs

2018-05-24 Thread Stefan Hajnoczi
On Thu, May 24, 2018 at 12:39:51PM +0800, Peter Xu wrote: > Add some explicit comment for both Readline and cpu_set/cpu_get helpers > that they do not need the mon_lock protection. > > Signed-off-by: Peter Xu > --- > monitor.c | 12 +++- > 1 file changed, 11

[Qemu-devel] [PATCH v7 3/4] monitor: more comments on lock-free fleids/funcs

2018-05-23 Thread Peter Xu
Add some explicit comment for both Readline and cpu_set/cpu_get helpers that they do not need the mon_lock protection. Signed-off-by: Peter Xu --- monitor.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index