Re: [Qemu-devel] [PATCH v7 30/38] qtest: Avoid passing raw strings through hmp()

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:20, Eric Blake wrote: > hmp() passes its string argument through the sprintf() family; > with a proper attribute, gcc -Wformat warns us when we do something > dangerous like passing a non-constant format string. Fortunately, > all our strings were safe, but checking whether the st

Re: [Qemu-devel] [PATCH v7 30/38] qtest: Avoid passing raw strings through hmp()

2017-09-11 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > hmp() passes its string argument through the sprintf() family; > with a proper attribute, gcc -Wformat warns us when we do something > dangerous like passing a non-constant format string. Fortunately, > all our strings were safe, but checking whether the s

[Qemu-devel] [PATCH v7 30/38] qtest: Avoid passing raw strings through hmp()

2017-09-11 Thread Eric Blake
hmp() passes its string argument through the sprintf() family; with a proper attribute, gcc -Wformat warns us when we do something dangerous like passing a non-constant format string. Fortunately, all our strings were safe, but checking whether the string can contain an unintended % is easy to avo