Re: [Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets

2018-05-28 Thread Peter Xu
On Mon, May 28, 2018 at 05:19:08PM +0200, Markus Armbruster wrote: [...] > >> > >> > + * Meanwhile it can also be used even at the end of main. Let's keep > >> > + * it initialized for the whole lifecycle of QEMU. > >> > + */ > >> > >> Awkward question, since our main() is such a tangled

Re: [Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets

2018-05-28 Thread Markus Armbruster
Peter Xu writes: > On Thu, May 24, 2018 at 11:03:55AM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > Similar to previous patch, but introduce a new global big lock for >> > mon_fdsets. Take it where needed. >> >> The previous patch is

Re: [Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets

2018-05-28 Thread Peter Xu
On Thu, May 24, 2018 at 11:03:55AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Similar to previous patch, but introduce a new global big lock for > > mon_fdsets. Take it where needed. > > The previous patch is "monitor: more comments on lock-free >

Re: [Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets

2018-05-28 Thread Peter Xu
On Fri, May 25, 2018 at 10:01:57AM +0100, Stefan Hajnoczi wrote: > On Fri, May 25, 2018 at 11:30:22AM +0800, Peter Xu wrote: > > On Thu, May 24, 2018 at 10:28:37AM +0100, Stefan Hajnoczi wrote: > > > On Thu, May 24, 2018 at 12:39:52PM +0800, Peter Xu wrote: > > > > int

Re: [Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets

2018-05-25 Thread Stefan Hajnoczi
On Fri, May 25, 2018 at 11:30:22AM +0800, Peter Xu wrote: > On Thu, May 24, 2018 at 10:28:37AM +0100, Stefan Hajnoczi wrote: > > On Thu, May 24, 2018 at 12:39:52PM +0800, Peter Xu wrote: > > > int monitor_fdset_get_fd(int64_t fdset_id, int flags) > > > { > > > -#ifndef _WIN32 > > > +#ifdef

Re: [Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets

2018-05-24 Thread Peter Xu
On Thu, May 24, 2018 at 10:28:37AM +0100, Stefan Hajnoczi wrote: > On Thu, May 24, 2018 at 12:39:52PM +0800, Peter Xu wrote: > > int monitor_fdset_get_fd(int64_t fdset_id, int flags) > > { > > -#ifndef _WIN32 > > +#ifdef _WIN32 > > +return -ENOENT; > > stubs/fdset.c:monitor_fdset_get_fd()

Re: [Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets

2018-05-24 Thread Stefan Hajnoczi
On Thu, May 24, 2018 at 12:39:52PM +0800, Peter Xu wrote: > int monitor_fdset_get_fd(int64_t fdset_id, int flags) > { > -#ifndef _WIN32 > +#ifdef _WIN32 > +return -ENOENT; stubs/fdset.c:monitor_fdset_get_fd() should return -ENOENT instead of -1 now. signature.asc Description: PGP

Re: [Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets

2018-05-24 Thread Markus Armbruster
Peter Xu writes: > Similar to previous patch, but introduce a new global big lock for > mon_fdsets. Take it where needed. The previous patch is "monitor: more comments on lock-free fleids/funcs". Sure you mean that one? > > The monitor_fdset_get_fd() handling is a bit

[Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets

2018-05-23 Thread Peter Xu
Similar to previous patch, but introduce a new global big lock for mon_fdsets. Take it where needed. The monitor_fdset_get_fd() handling is a bit tricky: now we need to call qemu_mutex_unlock() which might pollute errno, so we need to make sure the correct errno be passed up to the callers. To