Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-11 Thread Eric Blake
On 02/11/2014 12:19 AM, Paolo Bonzini wrote: Il 11/02/2014 03:47, Luiz Capitulino ha scritto: On Tue, 11 Feb 2014 00:34:37 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 11/02/2014 00:30, Laszlo Ersek ha scritto: However, I don't see the point in having the format-option field. What

Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-10 Thread Luiz Capitulino
On Tue, 28 Jan 2014 14:22:06 +0800 qiaonuohan qiaonuo...@cn.fujitsu.com wrote: 'query-dump-guest-memory-capability' is used to query whether option 'format' is available for 'dump-guest-memory' and the available format. The output of the command will be like: - { execute:

Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-10 Thread Laszlo Ersek
On 02/10/14 20:10, Luiz Capitulino wrote: On Tue, 28 Jan 2014 14:22:06 +0800 qiaonuohan qiaonuo...@cn.fujitsu.com wrote: 'query-dump-guest-memory-capability' is used to query whether option 'format' is available for 'dump-guest-memory' and the available format. The output of the command

Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-10 Thread Paolo Bonzini
Il 10/02/2014 23:02, Laszlo Ersek ha scritto: On 02/10/14 20:10, Luiz Capitulino wrote: On Tue, 28 Jan 2014 14:22:06 +0800 qiaonuohan qiaonuo...@cn.fujitsu.com wrote: 'query-dump-guest-memory-capability' is used to query whether option 'format' is available for 'dump-guest-memory' and the

Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-10 Thread Paolo Bonzini
Il 10/02/2014 23:02, Laszlo Ersek ha scritto: On 02/10/14 20:10, Luiz Capitulino wrote: On Tue, 28 Jan 2014 14:22:06 +0800 qiaonuohan qiaonuo...@cn.fujitsu.com wrote: 'query-dump-guest-memory-capability' is used to query whether option 'format' is available for 'dump-guest-memory' and the

Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-10 Thread Laszlo Ersek
On 02/11/14 00:09, Paolo Bonzini wrote: Il 10/02/2014 23:02, Laszlo Ersek ha scritto: On 02/10/14 20:10, Luiz Capitulino wrote: On Tue, 28 Jan 2014 14:22:06 +0800 qiaonuohan qiaonuo...@cn.fujitsu.com wrote: 'query-dump-guest-memory-capability' is used to query whether option 'format' is

Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-10 Thread Paolo Bonzini
Il 11/02/2014 00:30, Laszlo Ersek ha scritto: However, I don't see the point in having the format-option field. What about: - { execute: query-dump-guest-memory-capabilities } - { return: { formats: [elf, kdump-zlib, kdump-lzo, kdump-snappy] } Technically you might be right.

Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-10 Thread Laszlo Ersek
On 02/11/14 00:34, Paolo Bonzini wrote: Luiz, can you apply patches 1-12 for now? I agree with Laszlo that, no matter how unfortunate this is, the unused warnings are a necessary evil and one that can be worked around easily when bisecting. Thanks, Paolo! In addition, Luiz, please consider

Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-10 Thread Qiao Nuohan
On 02/11/2014 08:22 AM, Laszlo Ersek wrote: On 02/11/14 00:34, Paolo Bonzini wrote: Luiz, can you apply patches 1-12 for now? I agree with Laszlo that, no matter how unfortunate this is, the unused warnings are a necessary evil and one that can be worked around easily when bisecting.

Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-10 Thread Luiz Capitulino
On Tue, 11 Feb 2014 00:34:37 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 11/02/2014 00:30, Laszlo Ersek ha scritto: However, I don't see the point in having the format-option field. What about: - { execute: query-dump-guest-memory-capabilities } - { return: { formats:

Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-10 Thread Qiao Nuohan
On 02/11/2014 10:47 AM, Luiz Capitulino wrote: On Tue, 11 Feb 2014 00:34:37 +0100 Paolo Bonzinipbonz...@redhat.com wrote: Il 11/02/2014 00:30, Laszlo Ersek ha scritto: However, I don't see the point in having the format-option field. What about: - { execute:

Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-10 Thread Paolo Bonzini
Il 11/02/2014 03:47, Luiz Capitulino ha scritto: On Tue, 11 Feb 2014 00:34:37 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 11/02/2014 00:30, Laszlo Ersek ha scritto: However, I don't see the point in having the format-option field. What about: - { execute:

[Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-01-27 Thread qiaonuohan
'query-dump-guest-memory-capability' is used to query whether option 'format' is available for 'dump-guest-memory' and the available format. The output of the command will be like: - { execute: query-dump-guest-memory-capability } - { return: { format-option: optional,