Re: [Qemu-devel] [PATCH v9 13/13] block/backup: use backup-top instead of write notifiers

2019-09-09 Thread Max Reitz
On 03.09.19 10:06, Vladimir Sementsov-Ogievskiy wrote: > 02.09.2019 19:34, Max Reitz wrote: [...] >> I’m not saying that we need to abandon having BBs right now, but I think >> there are a couple of cases which show why I say it’s uglier than using >> BdrvChildren instead. >> > > OK. I'd prefer

Re: [Qemu-devel] [PATCH v9 13/13] block/backup: use backup-top instead of write notifiers

2019-09-03 Thread Vladimir Sementsov-Ogievskiy
02.09.2019 19:34, Max Reitz wrote: > On 29.08.19 16:55, Vladimir Sementsov-Ogievskiy wrote: >> 28.08.2019 22:50, Max Reitz wrote: >>> On 26.08.19 18:13, Vladimir Sementsov-Ogievskiy wrote: Drop write notifiers and use filter node instead. = Changes = 1. add

Re: [Qemu-devel] [PATCH v9 13/13] block/backup: use backup-top instead of write notifiers

2019-09-02 Thread Max Reitz
On 29.08.19 16:55, Vladimir Sementsov-Ogievskiy wrote: > 28.08.2019 22:50, Max Reitz wrote: >> On 26.08.19 18:13, Vladimir Sementsov-Ogievskiy wrote: >>> Drop write notifiers and use filter node instead. >>> >>> = Changes = >>> >>> 1. add filter-node-name argument for backup qmp api. We have to do

Re: [Qemu-devel] [PATCH v9 13/13] block/backup: use backup-top instead of write notifiers

2019-08-29 Thread Vladimir Sementsov-Ogievskiy
28.08.2019 22:50, Max Reitz wrote: > On 26.08.19 18:13, Vladimir Sementsov-Ogievskiy wrote: >> Drop write notifiers and use filter node instead. >> >> = Changes = >> >> 1. add filter-node-name argument for backup qmp api. We have to do it >> in this commit, as 257 needs to be fixed. > > I feel a

Re: [Qemu-devel] [PATCH v9 13/13] block/backup: use backup-top instead of write notifiers

2019-08-28 Thread Max Reitz
On 26.08.19 18:13, Vladimir Sementsov-Ogievskiy wrote: > Drop write notifiers and use filter node instead. > > = Changes = > > 1. add filter-node-name argument for backup qmp api. We have to do it > in this commit, as 257 needs to be fixed. I feel a bit bad about it not being an implicit node.

[Qemu-devel] [PATCH v9 13/13] block/backup: use backup-top instead of write notifiers

2019-08-26 Thread Vladimir Sementsov-Ogievskiy
Drop write notifiers and use filter node instead. = Changes = 1. add filter-node-name argument for backup qmp api. We have to do it in this commit, as 257 needs to be fixed. 2. there no move write notifiers here, so is_write_notifier parameter is dropped from block-copy paths. 3. Intersecting