Re: [Qemu-devel] [PATCH v9 8/9] qcow2: Set the default cache-clean-interval to 10 minutes

2018-09-21 Thread Leonid Bloch
On 9/21/18 3:35 PM, Alberto Garcia wrote: On Tue 18 Sep 2018 05:29:22 PM CEST, Leonid Bloch wrote: /* New interval for cache cleanup timer */ r->cache_clean_interval = qemu_opt_get_number(opts, QCOW2_OPT_CACHE_CLEAN_INTERVAL, -

Re: [Qemu-devel] [PATCH v9 8/9] qcow2: Set the default cache-clean-interval to 10 minutes

2018-09-21 Thread Alberto Garcia
On Fri 21 Sep 2018 02:56:06 PM CEST, Kevin Wolf wrote: > Am 21.09.2018 um 14:35 hat Alberto Garcia geschrieben: >> On Tue 18 Sep 2018 05:29:22 PM CEST, Leonid Bloch wrote: >> > /* New interval for cache cleanup timer */ >> > r->cache_clean_interval = >> >

Re: [Qemu-devel] [PATCH v9 8/9] qcow2: Set the default cache-clean-interval to 10 minutes

2018-09-21 Thread Kevin Wolf
Am 21.09.2018 um 14:35 hat Alberto Garcia geschrieben: > On Tue 18 Sep 2018 05:29:22 PM CEST, Leonid Bloch wrote: > > /* New interval for cache cleanup timer */ > > r->cache_clean_interval = > > qemu_opt_get_number(opts, QCOW2_OPT_CACHE_CLEAN_INTERVAL, > > -

Re: [Qemu-devel] [PATCH v9 8/9] qcow2: Set the default cache-clean-interval to 10 minutes

2018-09-21 Thread Alberto Garcia
On Tue 18 Sep 2018 05:29:22 PM CEST, Leonid Bloch wrote: > /* New interval for cache cleanup timer */ > r->cache_clean_interval = > qemu_opt_get_number(opts, QCOW2_OPT_CACHE_CLEAN_INTERVAL, > -s->cache_clean_interval); > +

[Qemu-devel] [PATCH v9 8/9] qcow2: Set the default cache-clean-interval to 10 minutes

2018-09-18 Thread Leonid Bloch
The default cache-clean-interval is set to 10 minutes, in order to lower the overhead of the qcow2 caches (before the default was 0, i.e. disabled). Signed-off-by: Leonid Bloch Reviewed-by: Alberto Garcia --- block/qcow2.c| 2 +- block/qcow2.h| 1 + docs/qcow2-cache.txt | 4