[Qemu-devel] [PATCHv2 6/6] dump: fix memory region handling

2013-03-24 Thread Rabin Vincent
RAMBlock.offset does not provide the physical address of the memory region. This is available in the MemoryRegion's address. The wrong usage leads to incorrect physical addreses in the ELF. Fix it. Signed-off-by: Rabin Vincent ra...@rab.in --- dump.c| 19 +++

Re: [Qemu-devel] [PATCHv2 6/6] dump: fix memory region handling

2013-03-24 Thread Peter Maydell
On 24 March 2013 17:27, Rabin Vincent ra...@rab.in wrote: /** + * memory_region_get_addr: Get the address of a memory region + * + * @mr: the memory region + */ +hwaddr memory_region_get_addr(MemoryRegion *mr); I'm afraid this doesn't make sense. A MemoryRegion by itself has no address --

Re: [Qemu-devel] [PATCHv2 6/6] dump: fix memory region handling

2013-03-24 Thread Rabin Vincent
2013/3/24 Peter Maydell peter.mayd...@linaro.org: On 24 March 2013 17:27, Rabin Vincent ra...@rab.in wrote: /** + * memory_region_get_addr: Get the address of a memory region + * + * @mr: the memory region + */ +hwaddr memory_region_get_addr(MemoryRegion *mr); I'm afraid this doesn't

Re: [Qemu-devel] [PATCHv2 6/6] dump: fix memory region handling

2013-03-24 Thread Peter Maydell
On 24 March 2013 19:35, Rabin Vincent ra...@rab.in wrote: 2013/3/24 Peter Maydell peter.mayd...@linaro.org: On 24 March 2013 17:27, Rabin Vincent ra...@rab.in wrote: /** + * memory_region_get_addr: Get the address of a memory region + * + * @mr: the memory region + */ +hwaddr