Re: [Qemu-devel] [PATCHv3] block: add event when disk usage exceeds threshold

2014-12-02 Thread Francesco Romani
] [PATCHv3] block: add event when disk usage exceeds threshold Thanks for the quick review! Missing the change to the 'query-block' and 'query-named-block-nodes' examples to show the new always-present output field. Sorry, I missed the *examples* keyword. Will fix. -- Francesco Romani

Re: [Qemu-devel] [PATCHv3] block: add event when disk usage exceeds threshold

2014-12-02 Thread Stefan Hajnoczi
On Fri, Nov 28, 2014 at 01:31:07PM +0100, Francesco Romani wrote: @@ -82,6 +83,8 @@ BlockDeviceInfo *bdrv_block_device_info(BlockDriverState *bs) info-iops_size = cfg.op_size; } +info-write_threshold = bdrv_usage_threshold_get(bs); Overall looks good but I notice that

Re: [Qemu-devel] [PATCHv3] block: add event when disk usage exceeds threshold

2014-12-02 Thread Francesco Romani
] block: add event when disk usage exceeds threshold On Fri, Nov 28, 2014 at 01:31:07PM +0100, Francesco Romani wrote: @@ -82,6 +83,8 @@ BlockDeviceInfo *bdrv_block_device_info(BlockDriverState *bs) info-iops_size = cfg.op_size; } +info-write_threshold

Re: [Qemu-devel] [PATCHv3] block: add event when disk usage exceeds threshold

2014-12-01 Thread Eric Blake
On 11/28/2014 05:31 AM, Francesco Romani wrote: Managing applications, like oVirt (http://www.ovirt.org), make extensive use of thin-provisioned disk images. To let the guest run smoothly and be not unnecessarily paused, oVirt sets a disk usage threshold (so called 'high water mark') based on

Re: [Qemu-devel] [PATCHv3] block: add event when disk usage exceeds threshold

2014-12-01 Thread Francesco Romani
Subject: Re: [Qemu-devel] [PATCHv3] block: add event when disk usage exceeds threshold On 11/28/2014 05:31 AM, Francesco Romani wrote: Managing applications, like oVirt (http://www.ovirt.org), make extensive use of thin-provisioned disk images. To let the guest run smoothly

[Qemu-devel] [PATCHv3] block: add event when disk usage exceeds threshold

2014-11-28 Thread Francesco Romani
Managing applications, like oVirt (http://www.ovirt.org), make extensive use of thin-provisioned disk images. To let the guest run smoothly and be not unnecessarily paused, oVirt sets a disk usage threshold (so called 'high water mark') based on the occupation of the device, and automatically