Re: [Qemu-devel] [PATCHv3] qxl: move to UNDEFINED on DESTROY_ALL_SURFACES{, _ASYNC}

2011-06-30 Thread Gerd Hoffmann
Hi, Maybe add a "pending async" flag to catch such occasions? Yes, good idea. cheers, Gerd

Re: [Qemu-devel] [PATCHv3] qxl: move to UNDEFINED on DESTROY_ALL_SURFACES{, _ASYNC}

2011-06-29 Thread Alon Levy
On Wed, Jun 29, 2011 at 05:00:20PM +0200, Gerd Hoffmann wrote: > On 06/29/11 16:29, Alon Levy wrote: > >On Wed, Jun 29, 2011 at 03:09:36PM +0200, Gerd Hoffmann wrote: > >>Hi, > >> > >>>+case QXL_IO_DESTROY_ALL_SURFACES_ASYNC: +d->mode = > >>>QXL_MODE_UNDEFINED; > >> > >>Should go to the

Re: [Qemu-devel] [PATCHv3] qxl: move to UNDEFINED on DESTROY_ALL_SURFACES{, _ASYNC}

2011-06-29 Thread Alon Levy
On Wed, Jun 29, 2011 at 03:09:36PM +0200, Gerd Hoffmann wrote: > Hi, > > >+case QXL_IO_DESTROY_ALL_SURFACES_ASYNC: > >+d->mode = QXL_MODE_UNDEFINED; > > Should go to the async thread. doesn't it make more sense to do all state changes from the vcpu thread? async thread can run muc

Re: [Qemu-devel] [PATCHv3] qxl: move to UNDEFINED on DESTROY_ALL_SURFACES{, _ASYNC}

2011-06-29 Thread Gerd Hoffmann
On 06/29/11 16:29, Alon Levy wrote: On Wed, Jun 29, 2011 at 03:09:36PM +0200, Gerd Hoffmann wrote: Hi, +case QXL_IO_DESTROY_ALL_SURFACES_ASYNC: +d->mode = QXL_MODE_UNDEFINED; Should go to the async thread. doesn't it make more sense to do all state changes from the vcpu thread?

Re: [Qemu-devel] [PATCHv3] qxl: move to UNDEFINED on DESTROY_ALL_SURFACES{, _ASYNC}

2011-06-29 Thread Gerd Hoffmann
Hi, +case QXL_IO_DESTROY_ALL_SURFACES_ASYNC: +d->mode = QXL_MODE_UNDEFINED; Should go to the async thread. cheers, Gerd

[Qemu-devel] [PATCHv3] qxl: move to UNDEFINED on DESTROY_ALL_SURFACES{, _ASYNC}

2011-06-29 Thread Alon Levy
--- hw/qxl.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index f158d45..b794b2c 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1245,6 +1245,7 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val) qxl_spice_destroy_surface_wai