Re: [Qemu-devel] [PATCHv3 8/9] cleanup qemu_co_sendv(), qemu_co_recvv() and friends

2012-03-13 Thread Paolo Bonzini
Il 12/03/2012 20:14, Michael Tokarev ha scritto: The same as for non-coroutine versions in previous patches: rename arguments to be more obvious, change type of arguments from int to size_t where appropriate, and use common code for send and receive paths (with one extra argument) since these

Re: [Qemu-devel] [PATCHv3 8/9] cleanup qemu_co_sendv(), qemu_co_recvv() and friends

2012-03-13 Thread Paolo Bonzini
Il 13/03/2012 18:52, Paolo Bonzini ha scritto: Il 12/03/2012 20:14, Michael Tokarev ha scritto: The same as for non-coroutine versions in previous patches: rename arguments to be more obvious, change type of arguments from int to size_t where appropriate, and use common code for send and

Re: [Qemu-devel] [PATCHv3 8/9] cleanup qemu_co_sendv(), qemu_co_recvv() and friends

2012-03-13 Thread Michael Tokarev
On 13.03.2012 22:01, Paolo Bonzini wrote: ssize_t qemu_sendv_recvv(int sockfd, struct iovec *iov, size_t offset, size_t bytes, bool do_sendv); Hmm, since you are at it however, perhaps you could add an argument to these functions and qemu_sendv_recvv for the length

[Qemu-devel] [PATCHv3 8/9] cleanup qemu_co_sendv(), qemu_co_recvv() and friends

2012-03-12 Thread Michael Tokarev
The same as for non-coroutine versions in previous patches: rename arguments to be more obvious, change type of arguments from int to size_t where appropriate, and use common code for send and receive paths (with one extra argument) since these are exactly the same. Use common qemu_sendv_recvv()