Re: [Qemu-devel] [PATCHv5] add qemu-img convert -n option (skip target volume creation)

2013-08-30 Thread Eric Blake
On 08/26/2013 03:12 AM, Alex Bligh wrote: From: Alexandre Derumier aderum...@odiso.com Add a -n option to skip volume creation on qemu-img convert. This is useful for targets such as rbd / ceph, where the target volume may already exist; we cannot always rely on qemu-img convert to create

Re: [Qemu-devel] [PATCHv5] add qemu-img convert -n option (skip target volume creation)

2013-08-30 Thread Alex Bligh
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Eric, On 30 Aug 2013, at 18:31, Eric Blake wrote: for(;;) { -c = getopt(argc, argv, f:O:B:s:hce6o:pS:t:q); +c = getopt(argc, argv, f:O:B:s:hce6o:pS:t:qn); The order here... if (c == -1) { break;

Re: [Qemu-devel] [PATCHv5] add qemu-img convert -n option (skip target volume creation)

2013-08-30 Thread Alex Bligh
--On 30 August 2013 12:55:29 -0600 Eric Blake ebl...@redhat.com wrote: Yes, that looks like the best approach. Thanks - done in v6 and added your reviewed-by line -- Alex Bligh

Re: [Qemu-devel] [PATCHv5] add qemu-img convert -n option (skip target volume creation)

2013-08-30 Thread Eric Blake
On 08/30/2013 12:13 PM, Alex Bligh wrote: +# test of qemu-img convert -n - convert without creation +# +# Copyright (C) 2009 Red Hat, Inc. Where have you been the last 4 years? I could understand a range of years, if this test borrows significantly from another file that old, but I

[Qemu-devel] [PATCHv5] add qemu-img convert -n option (skip target volume creation)

2013-08-26 Thread Alex Bligh
From: Alexandre Derumier aderum...@odiso.com Add a -n option to skip volume creation on qemu-img convert. This is useful for targets such as rbd / ceph, where the target volume may already exist; we cannot always rely on qemu-img convert to create the image, as dependent on the output format,

[Qemu-devel] [PATCHv5] add qemu-img convert -n option (skip target volume creation)

2013-08-26 Thread Alex Bligh
Add a qemu-img convert -n option to skip target volume creation Changes since v5: * Fail conversion if the existing output image is smaller than the input image and the -n option is specified * Use -n not -C * Add a test routine Alexandre Derumier (1): add qemu-img convert -n option (skip