Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

2018-01-10 Thread Pavel Dovgalyuk
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > On 10 January 2018 at 07:04, Pavel Dovgalyuk wrote: > > The failure cause is in incorrect interrupt processing. > > When ARM processes hardware interrupt in arm_cpu_exec_interrupt(), > > it executes cs->exception_index

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

2018-01-10 Thread Peter Maydell
On 10 January 2018 at 07:04, Pavel Dovgalyuk wrote: > The failure cause is in incorrect interrupt processing. > When ARM processes hardware interrupt in arm_cpu_exec_interrupt(), > it executes cs->exception_index = excp_idx; > > This assumes, that the exception will be

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

2018-01-09 Thread Pavel Dovgalyuk
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > On 9 January 2018 at 13:21, Pavel Dovgalyuk wrote: > > I tried to get some logs with the following code. > > It prints that there was an exception 5 and it was overwritten by the > > standard code. > > Fixed code

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

2018-01-09 Thread Peter Maydell
On 9 January 2018 at 13:21, Pavel Dovgalyuk wrote: > I tried to get some logs with the following code. > It prints that there was an exception 5 and it was overwritten by the > standard code. > Fixed code prevents this overwrite. > > I guess that one of the following is true:

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

2018-01-09 Thread Pavel Dovgalyuk
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > On 20 November 2017 at 11:06, Peter Maydell wrote: > > On 20 November 2017 at 10:25, Pavel Dovgalyuk wrote: > >>> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > >>> On 17 November

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

2017-11-20 Thread Paolo Bonzini
On 20/11/2017 13:50, Peter Maydell wrote: > More generally, this commit seems to assume that QEMU always > does: > * set exception_index to something > * handle that > * clear exception_index to -1 > > but it's not clear to me that it's actually always the case > that it gets cleared back to

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

2017-11-20 Thread Peter Maydell
On 20 November 2017 at 11:06, Peter Maydell wrote: > On 20 November 2017 at 10:25, Pavel Dovgalyuk wrote: >>> From: Peter Maydell [mailto:peter.mayd...@linaro.org] >>> On 17 November 2017 at 20:26, Paolo Bonzini wrote: >>> > On

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

2017-11-20 Thread Peter Maydell
On 20 November 2017 at 10:25, Pavel Dovgalyuk wrote: >> From: Peter Maydell [mailto:peter.mayd...@linaro.org] >> On 17 November 2017 at 20:26, Paolo Bonzini wrote: >> > On 17/11/2017 21:07, Peter Maydell wrote: >> >> Hi. This commit breaks booting of

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

2017-11-20 Thread Pavel Dovgalyuk
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > On 17 November 2017 at 20:26, Paolo Bonzini wrote: > > On 17/11/2017 21:07, Peter Maydell wrote: > >> Hi. This commit breaks booting of Debian on aarch64 virt board. > >> (repro instructions for creating the image

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

2017-11-17 Thread Peter Maydell
On 17 November 2017 at 20:26, Paolo Bonzini wrote: > On 17/11/2017 21:07, Peter Maydell wrote: >> Hi. This commit breaks booting of Debian on aarch64 virt board. >> (repro instructions for creating the image available at: >>

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

2017-11-17 Thread Paolo Bonzini
On 17/11/2017 21:07, Peter Maydell wrote: > On 16 November 2017 at 11:59, Paolo Bonzini wrote: >> From: Pavel Dovgalyuk >> >> This patch adds a condition before overwriting exception_index fiels. >> It is needed when exception_index is already set

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

2017-11-17 Thread Peter Maydell
On 16 November 2017 at 11:59, Paolo Bonzini wrote: > From: Pavel Dovgalyuk > > This patch adds a condition before overwriting exception_index fiels. > It is needed when exception_index is already set to some meaningful value. > > Signed-off-by:

[Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

2017-11-16 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch adds a condition before overwriting exception_index fiels. It is needed when exception_index is already set to some meaningful value. Signed-off-by: Pavel Dovgalyuk Message-Id: