Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

On 13/12/2017 20:59, Alexander Graf wrote: > > > On 13.12.17 20:29, Laurent Vivier wrote: >> On 13/12/2017 20:19, Alexander Graf wrote: >>> >>> >>> On 02.02.17 06:14, David Gibson wrote: From: Laurent Vivier This is a port to ppc of the i386 commit:

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

On 13/12/2017 20:59, Alexander Graf wrote: > > > On 13.12.17 20:29, Laurent Vivier wrote: >> On 13/12/2017 20:19, Alexander Graf wrote: >>> >>> >>> On 02.02.17 06:14, David Gibson wrote: From: Laurent Vivier This is a port to ppc of the i386 commit:

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

On 13.12.17 20:29, Laurent Vivier wrote: > On 13/12/2017 20:19, Alexander Graf wrote: >> >> >> On 02.02.17 06:14, David Gibson wrote: >>> From: Laurent Vivier >>> >>> This is a port to ppc of the i386 commit: >>> 00f4d64 kvmclock: clock should count only if vm is running

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

On 13.12.17 20:29, Laurent Vivier wrote: > On 13/12/2017 20:19, Alexander Graf wrote: >> >> >> On 02.02.17 06:14, David Gibson wrote: >>> From: Laurent Vivier >>> >>> This is a port to ppc of the i386 commit: >>> 00f4d64 kvmclock: clock should count only if vm is running

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

On 13/12/2017 20:19, Alexander Graf wrote: > > > On 02.02.17 06:14, David Gibson wrote: >> From: Laurent Vivier >> >> This is a port to ppc of the i386 commit: >> 00f4d64 kvmclock: clock should count only if vm is running >> >> We remove timebase_post_load function, and

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

On 02.02.17 06:14, David Gibson wrote: > From: Laurent Vivier > > This is a port to ppc of the i386 commit: > 00f4d64 kvmclock: clock should count only if vm is running > > We remove timebase_post_load function, and use the VM state > change handler to save and restore

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

On 09/02/2017 14:11, Mark Cave-Ayland wrote: > On 07/02/17 15:46, Laurent Vivier wrote: > >>> If you do this enough times (maybe 10 or so?) you'll see the progress >>> bars stop working correctly and get out of sync, i.e. it will freeze for >>> long periods of time and then "jump" to catch-up but

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

On 07/02/17 15:46, Laurent Vivier wrote: >> If you do this enough times (maybe 10 or so?) you'll see the progress >> bars stop working correctly and get out of sync, i.e. it will freeze for >> long periods of time and then "jump" to catch-up but not all the way. >> >> With my above patch applied

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

On 02/02/2017 16:50, Mark Cave-Ayland wrote: > On 02/02/17 14:20, Laurent Vivier wrote: > >> I think adding the the PPCTimebase field and the VMSTATE_PPC_TIMEBASE_V >> macro to the PMac machines should fix your issue. >> >> Do you have a test case I can try? >> >> Laurent > > Hi Laurent, > >

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

On 02/02/17 14:20, Laurent Vivier wrote: > I think adding the the PPCTimebase field and the VMSTATE_PPC_TIMEBASE_V > macro to the PMac machines should fix your issue. > > Do you have a test case I can try? > > Laurent Hi Laurent, Yes I'd say that is required, although I still think you need

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

On 02/02/2017 11:40, Mark Cave-Ayland wrote: > On 02/02/17 09:13, Laurent Vivier wrote: > >> On 02/02/2017 09:37, Mark Cave-Ayland wrote: >>> On 02/02/17 05:14, David Gibson wrote: >>> >> ... >>> Hi David/Laurent, >> >> Hi Mark, >> >>> I just noticed this in your pull request today - this looks

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

On 02/02/17 09:13, Laurent Vivier wrote: > On 02/02/2017 09:37, Mark Cave-Ayland wrote: >> On 02/02/17 05:14, David Gibson wrote: >> > ... >> Hi David/Laurent, > > Hi Mark, > >> I just noticed this in your pull request today - this looks like it is >> along similar lines to the prototype patch

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

On 02/02/2017 09:37, Mark Cave-Ayland wrote: > On 02/02/17 05:14, David Gibson wrote: > ... > Hi David/Laurent, Hi Mark, > I just noticed this in your pull request today - this looks like it is > along similar lines to the prototype patch I proposed last year as part > of the decrementer

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

On 02/02/17 05:14, David Gibson wrote: > From: Laurent Vivier > > This is a port to ppc of the i386 commit: > 00f4d64 kvmclock: clock should count only if vm is running > > We remove timebase_post_load function, and use the VM state > change handler to save and restore

[Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

From: Laurent Vivier This is a port to ppc of the i386 commit: 00f4d64 kvmclock: clock should count only if vm is running We remove timebase_post_load function, and use the VM state change handler to save and restore the guest_timebase (on stop and continue). We keep