Re: [Qemu-devel] [PULL 1/8] target-sh4: use bit number for SR constants

2015-06-03 Thread Aurelien Jarno
On 2015-06-02 19:01, Christopher Covington wrote: Hi Aurelien, On 06/01/2015 05:29 PM, Aurelien Jarno wrote: Use the bit number for SR constants instead of using a bit mask. This make possible to also use the constants for shifts. Reviewed-by: Richard Henderson r...@twiddle.net

Re: [Qemu-devel] [PULL 1/8] target-sh4: use bit number for SR constants

2015-06-03 Thread Aurelien Jarno
On 2015-06-03 09:09, Aurelien Jarno wrote: On 2015-06-02 19:01, Christopher Covington wrote: Hi Aurelien, On 06/01/2015 05:29 PM, Aurelien Jarno wrote: Use the bit number for SR constants instead of using a bit mask. This make possible to also use the constants for shifts.

Re: [Qemu-devel] [PULL 1/8] target-sh4: use bit number for SR constants

2015-06-03 Thread Peter Maydell
On 3 June 2015 at 15:34, Aurelien Jarno aurel...@aurel32.net wrote: On 2015-06-03 09:09, Aurelien Jarno wrote: On 2015-06-02 19:01, Christopher Covington wrote: I like using the BIT() macro for this kind of thing. Thanks for the hint, I'll come with an additional patch to fix that in the

Re: [Qemu-devel] [PULL 1/8] target-sh4: use bit number for SR constants

2015-06-02 Thread Christopher Covington
Hi Aurelien, On 06/01/2015 05:29 PM, Aurelien Jarno wrote: Use the bit number for SR constants instead of using a bit mask. This make possible to also use the constants for shifts. Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Aurelien Jarno aurel...@aurel32.net ---

[Qemu-devel] [PULL 1/8] target-sh4: use bit number for SR constants

2015-06-01 Thread Aurelien Jarno
Use the bit number for SR constants instead of using a bit mask. This make possible to also use the constants for shifts. Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- target-sh4/cpu.c | 3 +- target-sh4/cpu.h | 30