Re: [Qemu-devel] [PULL 12/23] virtio: use VRingMemoryRegionCaches for avail and used rings

2017-02-23 Thread Cédric Le Goater
On 02/23/2017 10:47 AM, Paolo Bonzini wrote: > > > On 23/02/2017 10:33, Cédric Le Goater wrote: >> I still have migration issues with this patch on ppc, which fails >> on the target guest with : >> >> qemu-system-ppc64: VQ 0 size 0x80 < last_avail_idx 0xe1e - used_idx 0x0 >> qemu-system-ppc64:

Re: [Qemu-devel] [PULL 12/23] virtio: use VRingMemoryRegionCaches for avail and used rings

2017-02-23 Thread Paolo Bonzini
On 23/02/2017 10:33, Cédric Le Goater wrote: > I still have migration issues with this patch on ppc, which fails > on the target guest with : > > qemu-system-ppc64: VQ 0 size 0x80 < last_avail_idx 0xe1e - used_idx 0x0 > qemu-system-ppc64: Failed to load virtio-blk:virtio > qemu-system-ppc64:

Re: [Qemu-devel] [PULL 12/23] virtio: use VRingMemoryRegionCaches for avail and used rings

2017-02-23 Thread Cédric Le Goater
Hello, On 02/23/2017 01:32 AM, Alex Williamson wrote: > On Wed, 22 Feb 2017 10:03:56 +0100 > Paolo Bonzini wrote: > >> On 21/02/2017 18:54, Laszlo Ersek wrote: >>> Actually, QEMU segfaults. From the dmesg: >>> >>> [Tue Feb 21 18:47:28 2017] CPU 0/KVM[8298]: segfault at 48

Re: [Qemu-devel] [PULL 12/23] virtio: use VRingMemoryRegionCaches for avail and used rings

2017-02-22 Thread Alex Williamson
On Wed, 22 Feb 2017 10:03:56 +0100 Paolo Bonzini wrote: > On 21/02/2017 18:54, Laszlo Ersek wrote: > > Actually, QEMU segfaults. From the dmesg: > > > > [Tue Feb 21 18:47:28 2017] CPU 0/KVM[8298]: segfault at 48 ip > > 7fcb5dd02105 sp 7fcb49efc270 error 4 in > >

Re: [Qemu-devel] [PULL 12/23] virtio: use VRingMemoryRegionCaches for avail and used rings

2017-02-22 Thread Paolo Bonzini
On 21/02/2017 18:54, Laszlo Ersek wrote: > Actually, QEMU segfaults. From the dmesg: > > [Tue Feb 21 18:47:28 2017] CPU 0/KVM[8298]: segfault at 48 ip > 7fcb5dd02105 sp 7fcb49efc270 error 4 in > qemu-system-x86_64[7fcb5dae3000+905000] > > Complete backtrace below. (Thread 11 seems to

Re: [Qemu-devel] [PULL 12/23] virtio: use VRingMemoryRegionCaches for avail and used rings

2017-02-21 Thread Gerd Hoffmann
Hi, > The bug reproduces for me with current upstream OVMF. I sent a full QEMU > backtrace (SIGSEGV) in another message. I use libvirt (and I assume Gerd > does that too, because otherwise the shell would report the SIGSEGV > immediately). libvirt indeed, config attached. cheers, Gerd

Re: [Qemu-devel] [PULL 12/23] virtio: use VRingMemoryRegionCaches for avail and used rings

2017-02-21 Thread Laszlo Ersek
On 02/21/17 19:08, Paolo Bonzini wrote: > > > On 21/02/2017 13:57, Gerd Hoffmann wrote: >> This change breaks ovmf for me, although it isn't obvious to me why. >> Bisect landed here, and reverting indeed makes things going again. >> >> Using q35 machine type, pcie virtio devices, with the rhel

Re: [Qemu-devel] [PULL 12/23] virtio: use VRingMemoryRegionCaches for avail and used rings

2017-02-21 Thread Paolo Bonzini
On 21/02/2017 13:57, Gerd Hoffmann wrote: > This change breaks ovmf for me, although it isn't obvious to me why. > Bisect landed here, and reverting indeed makes things going again. > > Using q35 machine type, pcie virtio devices, with the rhel ovmf build >

Re: [Qemu-devel] [PULL 12/23] virtio: use VRingMemoryRegionCaches for avail and used rings

2017-02-21 Thread Laszlo Ersek
On 02/21/17 17:25, Laszlo Ersek wrote: > On 02/21/17 13:57, Gerd Hoffmann wrote: >> On Fr, 2017-02-17 at 21:54 +0200, Michael S. Tsirkin wrote: >>> From: Paolo Bonzini >>> >>> The virtio-net change is necessary because it uses virtqueue_fill >>> and virtqueue_flush instead of

Re: [Qemu-devel] [PULL 12/23] virtio: use VRingMemoryRegionCaches for avail and used rings

2017-02-21 Thread Laszlo Ersek
On 02/21/17 13:57, Gerd Hoffmann wrote: > On Fr, 2017-02-17 at 21:54 +0200, Michael S. Tsirkin wrote: >> From: Paolo Bonzini >> >> The virtio-net change is necessary because it uses virtqueue_fill >> and virtqueue_flush instead of the more convenient virtqueue_push. >> >>

Re: [Qemu-devel] [PULL 12/23] virtio: use VRingMemoryRegionCaches for avail and used rings

2017-02-21 Thread Gerd Hoffmann
On Fr, 2017-02-17 at 21:54 +0200, Michael S. Tsirkin wrote: > From: Paolo Bonzini > > The virtio-net change is necessary because it uses virtqueue_fill > and virtqueue_flush instead of the more convenient virtqueue_push. > > Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PULL 12/23] virtio: use VRingMemoryRegionCaches for avail and used rings

2017-02-17 Thread Michael S. Tsirkin
From: Paolo Bonzini The virtio-net change is necessary because it uses virtqueue_fill and virtqueue_flush instead of the more convenient virtqueue_push. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Reviewed-by: