Re: [Qemu-devel] [PULL 3/4] usb-mtp: prevent null dereference while deleting objects

2019-03-09 Thread Peter Maydell
On Fri, 8 Mar 2019 at 19:46, Bandan Das wrote: > This is very broken! I think something like this should work: > diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c > index 06e376bcd2..87a4bfb415 100644 > --- a/hw/usb/dev-mtp.c > +++ b/hw/usb/dev-mtp.c > @@ -1138,8 +1138,8 @@ static MTPData *usb_mtp_

Re: [Qemu-devel] [PULL 3/4] usb-mtp: prevent null dereference while deleting objects

2019-03-08 Thread Bandan Das
Peter Maydell writes: > On Thu, 7 Mar 2019 at 09:56, Gerd Hoffmann wrote: >> >> From: Bandan Das >> >> Spotted by Coverity: CID 1399144 >> >> Signed-off-by: Bandan Das >> Message-id: 20190306210409.14842-4-...@redhat.com >> Signed-off-by: Gerd Hoffmann >> --- >> hw/usb/dev-mtp.c | 4 +--- >>

Re: [Qemu-devel] [PULL 3/4] usb-mtp: prevent null dereference while deleting objects

2019-03-08 Thread Peter Maydell
On Thu, 7 Mar 2019 at 09:56, Gerd Hoffmann wrote: > > From: Bandan Das > > Spotted by Coverity: CID 1399144 > > Signed-off-by: Bandan Das > Message-id: 20190306210409.14842-4-...@redhat.com > Signed-off-by: Gerd Hoffmann > --- > hw/usb/dev-mtp.c | 4 +--- > 1 file changed, 1 insertion(+), 3 de

[Qemu-devel] [PULL 3/4] usb-mtp: prevent null dereference while deleting objects

2019-03-07 Thread Gerd Hoffmann
From: Bandan Das Spotted by Coverity: CID 1399144 Signed-off-by: Bandan Das Message-id: 20190306210409.14842-4-...@redhat.com Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 1f22