Re: [Qemu-devel] [PULL 3/8] vfio: Generalize region support

2016-03-10 Thread Alex Williamson
On Thu, 10 Mar 2016 13:46:06 -0700 Eric Blake wrote: > On 03/10/2016 09:34 AM, Alex Williamson wrote: > > >>> +trace_vfio_msix_fixup(vdev->vbasedev.name, > >>> + vdev->msix->table_bar, > >>> region->mmaps[0].offset, > >>> +

Re: [Qemu-devel] [PULL 3/8] vfio: Generalize region support

2016-03-10 Thread Eric Blake
On 03/10/2016 09:34 AM, Alex Williamson wrote: >>> +trace_vfio_msix_fixup(vdev->vbasedev.name, >>> + vdev->msix->table_bar, >>> region->mmaps[0].offset, >>> + region->mmaps[0].offset + >>> region->mmaps[0].size); >> Sorry

[Qemu-devel] [PULL 3/8] vfio: Generalize region support

2016-03-10 Thread Alex Williamson
Both platform and PCI vfio drivers create a "slow", I/O memory region with one or more mmap memory regions overlayed when supported by the device. Generalize this to a set of common helpers in the core that pulls the region info from vfio, fills the region data, configures slow mapping, and adds

Re: [Qemu-devel] [PULL 3/8] vfio: Generalize region support

2016-03-10 Thread Alex Williamson
On Thu, 10 Mar 2016 01:54:45 +0100 Eric Auger wrote: > Hi Alex, > On 03/09/2016 08:53 PM, Alex Williamson wrote: > > Both platform and PCI vfio drivers create a "slow", I/O memory region > > with one or more mmap memory regions overlayed when supported by the > > device.

Re: [Qemu-devel] [PULL 3/8] vfio: Generalize region support

2016-03-09 Thread Eric Auger
Hi Alex, On 03/09/2016 08:53 PM, Alex Williamson wrote: > Both platform and PCI vfio drivers create a "slow", I/O memory region > with one or more mmap memory regions overlayed when supported by the > device. Generalize this to a set of common helpers in the core that > pulls the region info from

[Qemu-devel] [PULL 3/8] vfio: Generalize region support

2016-03-09 Thread Alex Williamson
Both platform and PCI vfio drivers create a "slow", I/O memory region with one or more mmap memory regions overlayed when supported by the device. Generalize this to a set of common helpers in the core that pulls the region info from vfio, fills the region data, configures slow mapping, and adds