Re: [Qemu-devel] [PULL 6/6] hw/usb/dev-serial: Do not try to set vendorid or productid properties

2017-05-19 Thread Thomas Huth
On 19.05.2017 07:54, Markus Armbruster wrote: > Thomas Huth writes: > >> On 18.05.2017 15:35, Paolo Bonzini wrote: >>> >>> >>> On 18/05/2017 15:22, Thomas Huth wrote: On 18.05.2017 14:00, Paolo Bonzini wrote: > > > On 12/05/2017 14:21, Gerd Hoffmann wrote:

Re: [Qemu-devel] [PULL 6/6] hw/usb/dev-serial: Do not try to set vendorid or productid properties

2017-05-18 Thread Markus Armbruster
Thomas Huth writes: > On 18.05.2017 15:35, Paolo Bonzini wrote: >> >> >> On 18/05/2017 15:22, Thomas Huth wrote: >>> On 18.05.2017 14:00, Paolo Bonzini wrote: On 12/05/2017 14:21, Gerd Hoffmann wrote: > From: Thomas Huth > > When

Re: [Qemu-devel] [PULL 6/6] hw/usb/dev-serial: Do not try to set vendorid or productid properties

2017-05-18 Thread Gerd Hoffmann
Hi, > >> Feel free to send an additional cleanup patch ... otherwise, I'd say let > >> it bitrot for another year and we then remove it completely together > >> with all the other "-usbdevice" functions... > > > > Well, Coverity reports it so I'd rather keep it clean... It will be clean once

Re: [Qemu-devel] [PULL 6/6] hw/usb/dev-serial: Do not try to set vendorid or productid properties

2017-05-18 Thread Thomas Huth
On 18.05.2017 15:35, Paolo Bonzini wrote: > > > On 18/05/2017 15:22, Thomas Huth wrote: >> On 18.05.2017 14:00, Paolo Bonzini wrote: >>> >>> >>> On 12/05/2017 14:21, Gerd Hoffmann wrote: From: Thomas Huth When starting QEMU with the legacy USB serial device like

Re: [Qemu-devel] [PULL 6/6] hw/usb/dev-serial: Do not try to set vendorid or productid properties

2017-05-18 Thread Paolo Bonzini
On 18/05/2017 15:22, Thomas Huth wrote: > On 18.05.2017 14:00, Paolo Bonzini wrote: >> >> >> On 12/05/2017 14:21, Gerd Hoffmann wrote: >>> From: Thomas Huth >>> >>> When starting QEMU with the legacy USB serial device like this: >>> >>> qemu-system-x86_64 -usbdevice

Re: [Qemu-devel] [PULL 6/6] hw/usb/dev-serial: Do not try to set vendorid or productid properties

2017-05-18 Thread Thomas Huth
On 18.05.2017 14:00, Paolo Bonzini wrote: > > > On 12/05/2017 14:21, Gerd Hoffmann wrote: >> From: Thomas Huth >> >> When starting QEMU with the legacy USB serial device like this: >> >> qemu-system-x86_64 -usbdevice serial:vendorid=0x1234:stdio >> >> it currently aborts

Re: [Qemu-devel] [PULL 6/6] hw/usb/dev-serial: Do not try to set vendorid or productid properties

2017-05-18 Thread Paolo Bonzini
On 12/05/2017 14:21, Gerd Hoffmann wrote: > From: Thomas Huth > > When starting QEMU with the legacy USB serial device like this: > > qemu-system-x86_64 -usbdevice serial:vendorid=0x1234:stdio > > it currently aborts since the vendorid property does not exist > anymore (it

[Qemu-devel] [PULL 6/6] hw/usb/dev-serial: Do not try to set vendorid or productid properties

2017-05-12 Thread Gerd Hoffmann
From: Thomas Huth When starting QEMU with the legacy USB serial device like this: qemu-system-x86_64 -usbdevice serial:vendorid=0x1234:stdio it currently aborts since the vendorid property does not exist anymore (it has been removed by commit f29783f72ea77dfbd7ea0c9):