Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-31 Thread KONRAD Frederic
On 07/28/2017 12:13 PM, Peter Maydell wrote: On 28 July 2017 at 10:18, Peter Maydell wrote: Talking to David about this on IRC, even "don't allow migration" is a bit tricky, because you can't register a migration-blocker if a migration is already in progress. Two

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-28 Thread Peter Maydell
On 28 July 2017 at 10:18, Peter Maydell wrote: > Talking to David about this on IRC, even "don't allow > migration" is a bit tricky, because you can't register > a migration-blocker if a migration is already in progress. > Two further options: > * disable this

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-28 Thread Peter Maydell
On 20 July 2017 at 10:42, Peter Maydell wrote: > OK, so what should we do for 2.10 ? > > We could: > * implement the changes you suggest above, and mark only >vmstate_register_ram'd blocks as migratable >(would probably need to fix some places which buggily >

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-27 Thread Juan Quintela
Peter Maydell wrote: > On 21 July 2017 at 10:13, Dr. David Alan Gilbert wrote: >> I don't fully understand the way memory_region_do_invalidate_mmio_ptr >> works; I see it dropping the memory region; if that's also dropping >> the RAMBlock then it

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-27 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * KONRAD Frederic (frederic.kon...@adacore.com) wrote: >> >> >> >> Let's imagine somebody (eg: u-boot guest) wants to execute code >> from the LQSPI area. >> >> memory_region_request_mmio_ptr is called (the guest is not >> running yet)

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-21 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 21 July 2017 at 10:13, Dr. David Alan Gilbert wrote: > > I don't fully understand the way memory_region_do_invalidate_mmio_ptr > > works; I see it dropping the memory region; if that's also dropping > > the RAMBlock then

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-21 Thread KONRAD Frederic
On 07/21/2017 11:29 AM, Peter Maydell wrote: On 21 July 2017 at 10:13, Dr. David Alan Gilbert wrote: I don't fully understand the way memory_region_do_invalidate_mmio_ptr works; I see it dropping the memory region; if that's also dropping the RAMBlock then it will upset

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-21 Thread KONRAD Frederic
On 07/21/2017 11:27 AM, Dr. David Alan Gilbert wrote: * KONRAD Frederic (frederic.kon...@adacore.com) wrote: On 07/20/2017 12:02 PM, Dr. David Alan Gilbert wrote: * Peter Maydell (peter.mayd...@linaro.org) wrote: On 17 July 2017 at 19:58, Dr. David Alan Gilbert

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-21 Thread Peter Maydell
On 21 July 2017 at 10:13, Dr. David Alan Gilbert wrote: > I don't fully understand the way memory_region_do_invalidate_mmio_ptr > works; I see it dropping the memory region; if that's also dropping > the RAMBlock then it will upset migration. Even if the CPU is stopped > I

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-21 Thread Dr. David Alan Gilbert
* KONRAD Frederic (frederic.kon...@adacore.com) wrote: > > > On 07/20/2017 12:02 PM, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > > On 17 July 2017 at 19:58, Dr. David Alan Gilbert > > > wrote: > > > > * Edgar E. Iglesias

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-21 Thread Dr. David Alan Gilbert
* KONRAD Frederic (frederic.kon...@adacore.com) wrote: > > > On 07/20/2017 12:02 PM, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > > On 17 July 2017 at 19:58, Dr. David Alan Gilbert > > > wrote: > > > > * Edgar E. Iglesias

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-21 Thread KONRAD Frederic
On 07/20/2017 12:02 PM, Dr. David Alan Gilbert wrote: * Peter Maydell (peter.mayd...@linaro.org) wrote: On 17 July 2017 at 19:58, Dr. David Alan Gilbert wrote: * Edgar E. Iglesias (edgar.igles...@gmail.com) wrote: Is there a way we can prevent migration of the

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-20 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 17 July 2017 at 19:58, Dr. David Alan Gilbert wrote: > > * Edgar E. Iglesias (edgar.igles...@gmail.com) wrote: > >> Is there a way we can prevent migration of the RAMBlock? > > > > Not yet, I think we'd have to: > >a)

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-20 Thread KONRAD Frederic
On 07/20/2017 11:42 AM, Peter Maydell wrote: On 17 July 2017 at 19:58, Dr. David Alan Gilbert wrote: * Edgar E. Iglesias (edgar.igles...@gmail.com) wrote: Is there a way we can prevent migration of the RAMBlock? Not yet, I think we'd have to: a) Add a flag to the

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-20 Thread Peter Maydell
On 17 July 2017 at 19:58, Dr. David Alan Gilbert wrote: > * Edgar E. Iglesias (edgar.igles...@gmail.com) wrote: >> Is there a way we can prevent migration of the RAMBlock? > > Not yet, I think we'd have to: >a) Add a flag to the RAMBlock >b) Set it/clear it on

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-20 Thread KONRAD Frederic
On 07/19/2017 06:46 PM, Dr. David Alan Gilbert wrote: * KONRAD Frederic (frederic.kon...@adacore.com) wrote: On 07/19/2017 02:29 PM, Dr. David Alan Gilbert wrote: * KONRAD Frederic (frederic.kon...@adacore.com) wrote: On 07/17/2017 07:27 PM, Edgar E. Iglesias wrote: On Mon, Jul 17,

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-20 Thread KONRAD Frederic
On 07/19/2017 06:25 PM, Peter Maydell wrote: On 19 July 2017 at 17:22, KONRAD Frederic wrote: Scary.. Yes your right. I still think it doesn't need to be migrated.. But how.. BTW taking a look at this I found the comment below which seems to implies that the

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-19 Thread Dr. David Alan Gilbert
* KONRAD Frederic (frederic.kon...@adacore.com) wrote: > > > On 07/19/2017 02:29 PM, Dr. David Alan Gilbert wrote: > > * KONRAD Frederic (frederic.kon...@adacore.com) wrote: > > > > > > > > > On 07/17/2017 07:27 PM, Edgar E. Iglesias wrote: > > > > On Mon, Jul 17, 2017 at 11:33 PM, Peter

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-19 Thread Peter Maydell
On 19 July 2017 at 17:22, KONRAD Frederic wrote: > Scary.. Yes your right. I still think it doesn't need to be > migrated.. But how.. > > BTW taking a look at this I found the comment below which seems > to implies that the content won't be migrated? That's a comment

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-19 Thread KONRAD Frederic
On 07/19/2017 02:29 PM, Dr. David Alan Gilbert wrote: * KONRAD Frederic (frederic.kon...@adacore.com) wrote: On 07/17/2017 07:27 PM, Edgar E. Iglesias wrote: On Mon, Jul 17, 2017 at 11:33 PM, Peter Maydell wrote: On 14 June 2017 at 18:45, Edgar E. Iglesias

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-19 Thread Dr. David Alan Gilbert
* KONRAD Frederic (frederic.kon...@adacore.com) wrote: > > > On 07/17/2017 07:27 PM, Edgar E. Iglesias wrote: > > On Mon, Jul 17, 2017 at 11:33 PM, Peter Maydell > > wrote: > > > > > On 14 June 2017 at 18:45, Edgar E. Iglesias > > > wrote: >

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-18 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 17 July 2017 at 19:58, Dr. David Alan Gilbert wrote: > > * Edgar E. Iglesias (edgar.igles...@gmail.com) wrote: > >> Is there a way we can prevent migration of the RAMBlock? > > > > Not yet, I think we'd have to: > >a)

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-18 Thread KONRAD Frederic
On 07/17/2017 07:27 PM, Edgar E. Iglesias wrote: On Mon, Jul 17, 2017 at 11:33 PM, Peter Maydell wrote: On 14 June 2017 at 18:45, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Paolo suggested offline that

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-17 Thread Peter Maydell
On 17 July 2017 at 19:58, Dr. David Alan Gilbert wrote: > * Edgar E. Iglesias (edgar.igles...@gmail.com) wrote: >> Is there a way we can prevent migration of the RAMBlock? > > Not yet, I think we'd have to: >a) Add a flag to the RAMBlock >b) Set it/clear it on

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-17 Thread Dr. David Alan Gilbert
* Edgar E. Iglesias (edgar.igles...@gmail.com) wrote: > On Mon, Jul 17, 2017 at 11:33 PM, Peter Maydell > wrote: > > > On 14 June 2017 at 18:45, Edgar E. Iglesias > > wrote: > > > From: "Edgar E. Iglesias" > > >

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-17 Thread Edgar E. Iglesias
On Mon, Jul 17, 2017 at 11:33 PM, Peter Maydell wrote: > On 14 June 2017 at 18:45, Edgar E. Iglesias > wrote: > > From: "Edgar E. Iglesias" > > Paolo suggested offline that we send a pull request for this series. >

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-07-17 Thread Peter Maydell
On 14 June 2017 at 18:45, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > Paolo suggested offline that we send a pull request for this series. > Here it is, I've run it through my testsuite + tested the LQSPI testcase > on Zynq. >

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-06-27 Thread Edgar E. Iglesias
On Fri, Jun 23, 2017 at 11:54:52AM +0100, Peter Maydell wrote: > On 14 June 2017 at 18:45, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Hi, > > > > Paolo suggested offline that we send a pull request for this series. > > Here

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-06-23 Thread KONRAD Frederic
Le 06/23/2017 à 12:54 PM, Peter Maydell a écrit : On 14 June 2017 at 18:45, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Hi, Paolo suggested offline that we send a pull request for this series. Here it is, I've run it through my

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-06-23 Thread Peter Maydell
On 14 June 2017 at 18:45, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Hi, > > Paolo suggested offline that we send a pull request for this series. > Here it is, I've run it through my testsuite + tested the LQSPI testcase > on

[Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-06-14 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Hi, Paolo suggested offline that we send a pull request for this series. Here it is, I've run it through my testsuite + tested the LQSPI testcase on Zynq. Cheers, Edgar The following changes since commit