Re: [Qemu-devel] [QEMU 3/7] Add the hmp and qmp interface for dropping cache

2016-06-16 Thread Li, Liang Z
> > > > +{ 'command': 'balloon_drop_cache', 'data': {'value': > > > > +'DropCacheType'} } > > > > > > Also, as noted in the man page quote above, it is recommended to > > > call > > > sync() to minimise dirty pages. Should we have a way to request a > > > sync as part of this monitor command. > >

Re: [Qemu-devel] [QEMU 3/7] Add the hmp and qmp interface for dropping cache

2016-06-13 Thread Li, Liang Z
> * Li, Liang Z (liang.z...@intel.com) wrote: > > > Because writing to this file is a nondestructive operation and dirty > > > objects are not freeable, the user should run sync(1) first. > > > [/quote] > > > > > > IOW, by 'slab' you mean dentries and inodes ? > > > > > Yes. > > > > > > +## > > >

Re: [Qemu-devel] [QEMU 3/7] Add the hmp and qmp interface for dropping cache

2016-06-13 Thread Dr. David Alan Gilbert
* Li, Liang Z (liang.z...@intel.com) wrote: > > Because writing to this file is a nondestructive operation and dirty > > objects are > > not freeable, the user should run sync(1) first. > > [/quote] > > > > IOW, by 'slab' you mean dentries and inodes ? > > > Yes. > > > > +## > > > +{

Re: [Qemu-devel] [QEMU 3/7] Add the hmp and qmp interface for dropping cache

2016-06-13 Thread Li, Liang Z
> > On 13/06/2016 12:50, Daniel P. Berrange wrote: > > More generally, it feels like this is taking as down a path towards > > actively managing the guest kernel VM from the host. Is this really a > > path we want to be going down, given that its going to take us into > > increasing non-portable

Re: [Qemu-devel] [QEMU 3/7] Add the hmp and qmp interface for dropping cache

2016-06-13 Thread Li, Liang Z
> On Mon, Jun 13, 2016 at 11:50:08AM +0100, Daniel P. Berrange wrote: > > On Mon, Jun 13, 2016 at 06:16:45PM +0800, Liang Li wrote: > > > Add the hmp and qmp interface to drop vm's page cache, users can > > > control the type of cache they want vm to drop. > > > > > > Signed-off-by: Liang Li

Re: [Qemu-devel] [QEMU 3/7] Add the hmp and qmp interface for dropping cache

2016-06-13 Thread Li, Liang Z
> Because writing to this file is a nondestructive operation and dirty objects > are > not freeable, the user should run sync(1) first. > [/quote] > > IOW, by 'slab' you mean dentries and inodes ? > Yes. > > +## > > +{ 'command': 'balloon_drop_cache', 'data': {'value': 'DropCacheType'} > > +}

Re: [Qemu-devel] [QEMU 3/7] Add the hmp and qmp interface for dropping cache

2016-06-13 Thread Paolo Bonzini
On 13/06/2016 12:50, Daniel P. Berrange wrote: > More generally, it feels like this is taking as down a path towards > actively managing the guest kernel VM from the host. Is this really > a path we want to be going down, given that its going to take us into > increasing non-portable concepts

Re: [Qemu-devel] [QEMU 3/7] Add the hmp and qmp interface for dropping cache

2016-06-13 Thread Daniel P. Berrange
On Mon, Jun 13, 2016 at 11:50:08AM +0100, Daniel P. Berrange wrote: > On Mon, Jun 13, 2016 at 06:16:45PM +0800, Liang Li wrote: > > Add the hmp and qmp interface to drop vm's page cache, users > > can control the type of cache they want vm to drop. > > > > Signed-off-by: Liang Li

Re: [Qemu-devel] [QEMU 3/7] Add the hmp and qmp interface for dropping cache

2016-06-13 Thread Daniel P. Berrange
On Mon, Jun 13, 2016 at 06:16:45PM +0800, Liang Li wrote: > Add the hmp and qmp interface to drop vm's page cache, users > can control the type of cache they want vm to drop. > > Signed-off-by: Liang Li > --- > balloon.c| 19 +++ > hmp-commands.hx

[Qemu-devel] [QEMU 3/7] Add the hmp and qmp interface for dropping cache

2016-06-13 Thread Liang Li
Add the hmp and qmp interface to drop vm's page cache, users can control the type of cache they want vm to drop. Signed-off-by: Liang Li --- balloon.c| 19 +++ hmp-commands.hx | 15 +++ hmp.c| 22 ++