Re: [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions

2012-07-24 Thread Blue Swirl
On Mon, Jul 23, 2012 at 8:14 PM, Eduardo Habkost wrote: > On Mon, Jul 23, 2012 at 07:44:44PM +, Blue Swirl wrote: >> On Mon, Jul 23, 2012 at 7:28 PM, Eduardo Habkost wrote: >> > On Mon, Jul 23, 2012 at 07:11:11PM +, Blue Swirl wrote: >> >> On Mon, Jul 23, 2012 at 6:59 PM, Eduardo Habkost

Re: [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions

2012-07-23 Thread Eduardo Habkost
On Mon, Jul 23, 2012 at 07:44:44PM +, Blue Swirl wrote: > On Mon, Jul 23, 2012 at 7:28 PM, Eduardo Habkost wrote: > > On Mon, Jul 23, 2012 at 07:11:11PM +, Blue Swirl wrote: > >> On Mon, Jul 23, 2012 at 6:59 PM, Eduardo Habkost > >> wrote: > >> > On Mon, Jul 23, 2012 at 04:49:07PM +,

Re: [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions

2012-07-23 Thread Blue Swirl
On Mon, Jul 23, 2012 at 7:28 PM, Eduardo Habkost wrote: > On Mon, Jul 23, 2012 at 07:11:11PM +, Blue Swirl wrote: >> On Mon, Jul 23, 2012 at 6:59 PM, Eduardo Habkost wrote: >> > On Mon, Jul 23, 2012 at 04:49:07PM +, Blue Swirl wrote: >> >> On Mon, Jul 16, 2012 at 5:42 PM, Eduardo Habkost

Re: [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions

2012-07-23 Thread Eduardo Habkost
On Mon, Jul 23, 2012 at 07:11:11PM +, Blue Swirl wrote: > On Mon, Jul 23, 2012 at 6:59 PM, Eduardo Habkost wrote: > > On Mon, Jul 23, 2012 at 04:49:07PM +, Blue Swirl wrote: > >> On Mon, Jul 16, 2012 at 5:42 PM, Eduardo Habkost > >> wrote: > >> > On Sat, Jul 14, 2012 at 09:14:30AM +,

Re: [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions

2012-07-23 Thread Blue Swirl
On Mon, Jul 23, 2012 at 6:59 PM, Eduardo Habkost wrote: > On Mon, Jul 23, 2012 at 04:49:07PM +, Blue Swirl wrote: >> On Mon, Jul 16, 2012 at 5:42 PM, Eduardo Habkost wrote: >> > On Sat, Jul 14, 2012 at 09:14:30AM +, Blue Swirl wrote: >> > [...] >> >> >> > diff --git a/tests/Makefile b/tes

Re: [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions

2012-07-23 Thread Eduardo Habkost
On Mon, Jul 23, 2012 at 04:49:07PM +, Blue Swirl wrote: > On Mon, Jul 16, 2012 at 5:42 PM, Eduardo Habkost wrote: > > On Sat, Jul 14, 2012 at 09:14:30AM +, Blue Swirl wrote: > > [...] > >> >> > diff --git a/tests/Makefile b/tests/Makefile > >> >> > index b605e14..89bd890 100644 > >> >> > -

Re: [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions

2012-07-23 Thread Blue Swirl
On Mon, Jul 16, 2012 at 5:42 PM, Eduardo Habkost wrote: > On Sat, Jul 14, 2012 at 09:14:30AM +, Blue Swirl wrote: > [...] >> >> > diff --git a/tests/Makefile b/tests/Makefile >> >> > index b605e14..89bd890 100644 >> >> > --- a/tests/Makefile >> >> > +++ b/tests/Makefile >> >> > @@ -15,6 +15,7

Re: [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions

2012-07-16 Thread Eduardo Habkost
On Sat, Jul 14, 2012 at 09:14:30AM +, Blue Swirl wrote: [...] > >> > diff --git a/tests/Makefile b/tests/Makefile > >> > index b605e14..89bd890 100644 > >> > --- a/tests/Makefile > >> > +++ b/tests/Makefile > >> > @@ -15,6 +15,7 @@ check-unit-y += > >> > tests/test-string-output-visitor$(EXESU

Re: [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions

2012-07-14 Thread Blue Swirl
On Fri, Jul 13, 2012 at 6:51 PM, Eduardo Habkost wrote: > On Thu, Jul 12, 2012 at 07:37:26PM +, Blue Swirl wrote: >> On Tue, Jul 10, 2012 at 8:22 PM, Eduardo Habkost wrote: > [...] >> > +#ifndef __QEMU_X86_TOPOLOGY_H__ >> > +#define __QEMU_X86_TOPOLOGY_H__ >> >> Please remove the leading and

Re: [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions

2012-07-13 Thread Eduardo Habkost
On Thu, Jul 12, 2012 at 07:37:26PM +, Blue Swirl wrote: > On Tue, Jul 10, 2012 at 8:22 PM, Eduardo Habkost wrote: [...] > > +#ifndef __QEMU_X86_TOPOLOGY_H__ > > +#define __QEMU_X86_TOPOLOGY_H__ > > Please remove the leading and trailing underscores. The name should > match the path, so it sho

Re: [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions

2012-07-12 Thread Blue Swirl
On Tue, Jul 10, 2012 at 8:22 PM, Eduardo Habkost wrote: > Signed-off-by: Eduardo Habkost > --- > target-i386/topology.h | 138 > > tests/.gitignore |1 + > tests/Makefile |7 ++- > tests/test-x86-cpuid.c | 108

[Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions

2012-07-10 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-i386/topology.h | 138 tests/.gitignore |1 + tests/Makefile |7 ++- tests/test-x86-cpuid.c | 108 + 4 files changed, 253 insertions(+), 1 deletio