Re: [Qemu-devel] [Qemu-arm] [PATCH 09/15] target/arm: Don't store M profile PRIMASK and FAULTMASK in daif

2017-08-04 Thread Edgar E. Iglesias
On Thu, Aug 03, 2017 at 03:05:17PM -0700, Richard Henderson wrote: > On 08/03/2017 08:38 AM, Edgar E. Iglesias wrote: > >> +uint32_t primask; > >> +uint32_t faultmask; > > It seems like these could be booleans? > > I was thinking the same thing until I read the v8m description as

Re: [Qemu-devel] [Qemu-arm] [PATCH 09/15] target/arm: Don't store M profile PRIMASK and FAULTMASK in daif

2017-08-03 Thread Richard Henderson
On 08/03/2017 08:38 AM, Edgar E. Iglesias wrote: >> +uint32_t primask; >> +uint32_t faultmask; > It seems like these could be booleans? I was thinking the same thing until I read the v8m description as a 32-bit register. This makes qemu match the spec, which has value. r~

Re: [Qemu-devel] [Qemu-arm] [PATCH 09/15] target/arm: Don't store M profile PRIMASK and FAULTMASK in daif

2017-08-03 Thread Edgar E. Iglesias
On Wed, Aug 02, 2017 at 05:43:55PM +0100, Peter Maydell wrote: > We currently store the M profile CPU register state PRIMASK and > FAULTMASK in the daif field of the CPU state in its I and F > bits. This is a legacy from the original implementation, which > tried to share the cpu_exec_interrupt