Re: [Qemu-devel] [Qemu-block] [PATCH 03/20] qcow2: Extend spec for external data files

2019-03-07 Thread Stefan Hajnoczi
On Wed, Mar 06, 2019 at 04:06:33PM +0100, Kevin Wolf wrote: > Maybe add a new section "String header extensions" that covers both? > > If this remains the only patch in the series that would need a > significant change, I'd prefer a follow-up patch indeed. A follow-up patch sounds good. Stefan

Re: [Qemu-devel] [Qemu-block] [PATCH 03/20] qcow2: Extend spec for external data files

2019-03-06 Thread Kevin Wolf
Am 06.03.2019 um 13:43 hat Eric Blake geschrieben: > On 3/6/19 3:51 AM, Stefan Hajnoczi wrote: > > On Fri, Mar 01, 2019 at 10:32:27AM -0600, Eric Blake wrote: > >> On 3/1/19 10:17 AM, Stefan Hajnoczi wrote: > >>> On Wed, Feb 27, 2019 at 06:22:39PM +0100, Kevin Wolf wrote: > @@ -148,6 +170,7 @@

Re: [Qemu-devel] [Qemu-block] [PATCH 03/20] qcow2: Extend spec for external data files

2019-03-06 Thread Eric Blake
On 3/6/19 3:51 AM, Stefan Hajnoczi wrote: > On Fri, Mar 01, 2019 at 10:32:27AM -0600, Eric Blake wrote: >> On 3/1/19 10:17 AM, Stefan Hajnoczi wrote: >>> On Wed, Feb 27, 2019 at 06:22:39PM +0100, Kevin Wolf wrote: @@ -148,6 +170,7 @@ be stored. Each extension has a structure like the fol

Re: [Qemu-devel] [Qemu-block] [PATCH 03/20] qcow2: Extend spec for external data files

2019-03-06 Thread Stefan Hajnoczi
On Fri, Mar 01, 2019 at 10:32:27AM -0600, Eric Blake wrote: > On 3/1/19 10:17 AM, Stefan Hajnoczi wrote: > > On Wed, Feb 27, 2019 at 06:22:39PM +0100, Kevin Wolf wrote: > >> @@ -148,6 +170,7 @@ be stored. Each extension has a structure like the > >> following: > >> 0x6803f

Re: [Qemu-devel] [Qemu-block] [PATCH 03/20] qcow2: Extend spec for external data files

2019-03-01 Thread Eric Blake
On 3/1/19 10:17 AM, Stefan Hajnoczi wrote: > On Wed, Feb 27, 2019 at 06:22:39PM +0100, Kevin Wolf wrote: >> -Bits 2-63: Reserved (set to 0) >> +Bit 2: External data file bit. If this bit is >> set, an >> +external data

Re: [Qemu-devel] [Qemu-block] [PATCH 03/20] qcow2: Extend spec for external data files

2019-03-01 Thread Stefan Hajnoczi
On Wed, Feb 27, 2019 at 06:22:39PM +0100, Kevin Wolf wrote: > -Bits 2-63: Reserved (set to 0) > +Bit 2: External data file bit. If this bit is set, > an > +external data file is used. Guest clusters > are > +