Re: [Qemu-devel] [Qemu-block] [PATCH v3] block: Turn on "unmap" in active commit

2016-09-30 Thread Kevin Wolf
Am 30.09.2016 um 04:12 hat Fam Zheng geschrieben: > On Thu, 09/29 13:41, Stefan Hajnoczi wrote: > > On Tue, Sep 27, 2016 at 07:14:52PM +0800, Fam Zheng wrote: > > > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > > > commit', but didn't turn on the "unmap" in the active commit

Re: [Qemu-devel] [Qemu-block] [PATCH v3] block: Turn on "unmap" in active commit

2016-09-30 Thread Stefan Hajnoczi
On Fri, Sep 30, 2016 at 10:12:05AM +0800, Fam Zheng wrote: > On Thu, 09/29 13:41, Stefan Hajnoczi wrote: > > On Tue, Sep 27, 2016 at 07:14:52PM +0800, Fam Zheng wrote: > > > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > > > commit', but didn't turn on the "unmap" in the

Re: [Qemu-devel] [Qemu-block] [PATCH v3] block: Turn on "unmap" in active commit

2016-09-29 Thread Fam Zheng
On Thu, 09/29 13:41, Stefan Hajnoczi wrote: > On Tue, Sep 27, 2016 at 07:14:52PM +0800, Fam Zheng wrote: > > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > > commit', but didn't turn on the "unmap" in the active commit job. This > > patch fixes that so that zeroed clusters in

Re: [Qemu-devel] [Qemu-block] [PATCH v3] block: Turn on "unmap" in active commit

2016-09-29 Thread Stefan Hajnoczi
On Tue, Sep 27, 2016 at 07:14:52PM +0800, Fam Zheng wrote: > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > commit', but didn't turn on the "unmap" in the active commit job. This > patch fixes that so that zeroed clusters in top image can be discarded > which is desired in