Re: [Qemu-devel] [Qemu-block] [RFC PATCH] block: local qiov helper

2019-01-29 Thread Stefan Hajnoczi
On Tue, Jan 29, 2019 at 01:34:48PM +0100, Kevin Wolf wrote: > Am 29.01.2019 um 12:18 hat Vladimir Sementsov-Ogievskiy geschrieben: > > 29.01.2019 13:32, Stefan Hajnoczi wrote: > > > On Tue, Jan 29, 2019 at 6:24 PM Vladimir Sementsov-Ogievskiy > > > wrote: > > >> 29.01.2019 6:31, Stefan Hajnoczi wr

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] block: local qiov helper

2019-01-29 Thread Kevin Wolf
Am 29.01.2019 um 12:18 hat Vladimir Sementsov-Ogievskiy geschrieben: > 29.01.2019 13:32, Stefan Hajnoczi wrote: > > On Tue, Jan 29, 2019 at 6:24 PM Vladimir Sementsov-Ogievskiy > > wrote: > >> 29.01.2019 6:31, Stefan Hajnoczi wrote: > >>> On Fri, Jan 25, 2019 at 07:46:01PM +0300, Vladimir Sementso

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] block: local qiov helper

2019-01-29 Thread Vladimir Sementsov-Ogievskiy
29.01.2019 13:32, Stefan Hajnoczi wrote: > On Tue, Jan 29, 2019 at 6:24 PM Vladimir Sementsov-Ogievskiy > wrote: >> 29.01.2019 6:31, Stefan Hajnoczi wrote: >>> On Fri, Jan 25, 2019 at 07:46:01PM +0300, Vladimir Sementsov-Ogievskiy >>> wrote: >> Hmm. In this case we definitely will have tiny extra

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] block: local qiov helper

2019-01-29 Thread Stefan Hajnoczi
On Tue, Jan 29, 2019 at 6:24 PM Vladimir Sementsov-Ogievskiy wrote: > 29.01.2019 6:31, Stefan Hajnoczi wrote: > > On Fri, Jan 25, 2019 at 07:46:01PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > Hmm. In this case we definitely will have tiny extra memory usage, but we > gain beautiful > reada

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] block: local qiov helper

2019-01-29 Thread Vladimir Sementsov-Ogievskiy
29.01.2019 6:31, Stefan Hajnoczi wrote: > On Fri, Jan 25, 2019 at 07:46:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Hi all. >> >> What about such a simple helper for a very often patter around >> qemu_iovec_init_external ? > > Sounds good, qemu_iovec_init() has 55 references vs > qemu_iovec

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] block: local qiov helper

2019-01-28 Thread Stefan Hajnoczi
On Fri, Jan 25, 2019 at 07:46:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > What about such a simple helper for a very often patter around > qemu_iovec_init_external ? Sounds good, qemu_iovec_init() has 55 references vs qemu_iovec_init_external() with 51. It's worth making qemu_i