Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-10 Thread Greg Kurz
On Thu, 10 Jan 2019 10:12:43 + Daniel P. Berrangé wrote: > On Wed, Jan 09, 2019 at 03:25:53PM -0600, Eric Blake wrote: > > On 1/9/19 3:20 PM, Paolo Bonzini wrote: > > > On 09/01/19 18:28, Daniel P. Berrangé wrote: > > >>> so both files include each other, how nice ... > > >> If the

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-10 Thread Daniel P . Berrangé
On Wed, Jan 09, 2019 at 03:25:53PM -0600, Eric Blake wrote: > On 1/9/19 3:20 PM, Paolo Bonzini wrote: > > On 09/01/19 18:28, Daniel P. Berrangé wrote: > >>> so both files include each other, how nice ... > >> If the header files are mutually dependent it makes me wonder what the > >> point of

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-09 Thread Thomas Huth
On 2019-01-09 18:47, Greg Kurz wrote: > On Wed, 9 Jan 2019 18:40:48 +0100 > Cédric Le Goater wrote: > >> On 1/9/19 6:28 PM, Daniel P. Berrangé wrote: >>> On Wed, Jan 09, 2019 at 06:13:01PM +0100, Cédric Le Goater wrote: On 1/9/19 5:39 PM, Thomas Huth wrote: > When compiling with

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-09 Thread Thomas Huth
On 2019-01-09 22:20, Paolo Bonzini wrote: > On 09/01/19 18:28, Daniel P. Berrangé wrote: >>> so both files include each other, how nice ... >> If the header files are mutually dependent it makes me wonder what the >> point of having them split up is ? >> >> Feels like either they need to be

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-09 Thread Paolo Bonzini
On 09/01/19 22:25, Eric Blake wrote: > On 1/9/19 3:20 PM, Paolo Bonzini wrote: >> On 09/01/19 18:28, Daniel P. Berrangé wrote: so both files include each other, how nice ... >>> If the header files are mutually dependent it makes me wonder what the >>> point of having them split up is ? >>>

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-09 Thread Eric Blake
On 1/9/19 3:20 PM, Paolo Bonzini wrote: > On 09/01/19 18:28, Daniel P. Berrangé wrote: >>> so both files include each other, how nice ... >> If the header files are mutually dependent it makes me wonder what the >> point of having them split up is ? >> >> Feels like either they need to be merged,

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-09 Thread Paolo Bonzini
On 09/01/19 18:28, Daniel P. Berrangé wrote: >> so both files include each other, how nice ... > If the header files are mutually dependent it makes me wonder what the > point of having them split up is ? > > Feels like either they need to be merged, or they need to be split up > and refactored

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-09 Thread Greg Kurz
On Wed, 9 Jan 2019 18:40:48 +0100 Cédric Le Goater wrote: > On 1/9/19 6:28 PM, Daniel P. Berrangé wrote: > > On Wed, Jan 09, 2019 at 06:13:01PM +0100, Cédric Le Goater wrote: > >> On 1/9/19 5:39 PM, Thomas Huth wrote: > >>> When compiling with Clang and -std=gnu99, I get the following

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-09 Thread Cédric Le Goater
On 1/9/19 5:39 PM, Thomas Huth wrote: > When compiling with Clang and -std=gnu99, I get the following errors: > > CC ppc64-softmmu/hw/intc/xics_spapr.o > In file included from hw/intc/xics_spapr.c:34: > include/hw/ppc/xics.h:46:25: error: redefinition of typedef 'ICSState' is a > C11

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-09 Thread Cédric Le Goater
On 1/9/19 6:28 PM, Daniel P. Berrangé wrote: > On Wed, Jan 09, 2019 at 06:13:01PM +0100, Cédric Le Goater wrote: >> On 1/9/19 5:39 PM, Thomas Huth wrote: >>> When compiling with Clang and -std=gnu99, I get the following errors: >>> >>> CC ppc64-softmmu/hw/intc/xics_spapr.o >>> In file

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-09 Thread Daniel P . Berrangé
On Wed, Jan 09, 2019 at 06:13:01PM +0100, Cédric Le Goater wrote: > On 1/9/19 5:39 PM, Thomas Huth wrote: > > When compiling with Clang and -std=gnu99, I get the following errors: > > > > CC ppc64-softmmu/hw/intc/xics_spapr.o > > In file included from hw/intc/xics_spapr.c:34: > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-09 Thread Cédric Le Goater
On 1/9/19 5:39 PM, Thomas Huth wrote: > When compiling with Clang and -std=gnu99, I get the following errors: > > CC ppc64-softmmu/hw/intc/xics_spapr.o > In file included from hw/intc/xics_spapr.c:34: > include/hw/ppc/xics.h:46:25: error: redefinition of typedef 'ICSState' is a > C11