Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-10-05 Thread Michael Tokarev
Okay. This takes just too long and too many people are affected. I'll just set the variable in question (caps) to NULL at entry for now, -- it is not a critical path and the current code is correct anyway. This is becoming ridiculous, when there are so many different opinions about such a

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-10-05 Thread Michael Tokarev
05.10.2013 13:15, Michael Tokarev пишет: Okay. This takes just too long and too many people are affected. I'll just set the variable in question (caps) to NULL at entry for now, -- it is not a critical path and the current code is correct anyway. This is becoming ridiculous, when there are so

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-10-05 Thread Stefan Weil
Am 05.10.2013 11:19, schrieb Michael Tokarev: Author: Michael Tokarev m...@tls.msk.ru Date: Sat Oct 5 13:18:28 2013 +0400 migration: Fix compiler warning ('caps' may be used uninitialized) Signed-off-by: Michael Tokarev m...@tls.msk.ru diff --git a/migration.c b/migration.c

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-10-03 Thread Paolo Bonzini
Il 02/10/2013 22:24, Stefan Weil ha scritto: Am 02.10.2013 21:02, schrieb Michael Tokarev: MigrationCapabilityStatusList *qmp_query_migrate_capabilities(Error **errp) { MigrationCapabilityStatusList *head = NULL; MigrationCapabilityStatusList *prev = NULL; MigrationState *s =

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-10-02 Thread Michael Tokarev
How about this: diff --git a/migration.c b/migration.c index b4f8462..6066ab4 100644 --- a/migration.c +++ b/migration.c @@ -146,22 +146,16 @@ uint64_t migrate_max_downtime(void) MigrationCapabilityStatusList *qmp_query_migrate_capabilities(Error **errp) { MigrationCapabilityStatusList

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-10-02 Thread Stefan Weil
Am 02.10.2013 21:02, schrieb Michael Tokarev: How about this: diff --git a/migration.c b/migration.c index b4f8462..6066ab4 100644 --- a/migration.c +++ b/migration.c @@ -146,22 +146,16 @@ uint64_t migrate_max_downtime(void) MigrationCapabilityStatusList

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-10-01 Thread Markus Armbruster
Stefan Weil s...@weilnetz.de writes: Am 30.09.2013 11:59, schrieb Markus Armbruster: Stefan Weil s...@weilnetz.de writes: Am 29.09.2013 22:13, schrieb Michael Tokarev: 29.09.2013 19:41, Stefan Weil wrote: The QEMU buildbot default_i386_debian_6_0 shows this warning: CCmigration.o

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-09-30 Thread Markus Armbruster
Stefan Weil s...@weilnetz.de writes: Am 29.09.2013 22:13, schrieb Michael Tokarev: 29.09.2013 19:41, Stefan Weil wrote: The QEMU buildbot default_i386_debian_6_0 shows this warning: CCmigration.o migration.c: In function 'qmp_query_migrate_capabilities': migration.c:149: warning:

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-09-30 Thread Stefan Weil
Am 30.09.2013 11:59, schrieb Markus Armbruster: Stefan Weil s...@weilnetz.de writes: Am 29.09.2013 22:13, schrieb Michael Tokarev: 29.09.2013 19:41, Stefan Weil wrote: The QEMU buildbot default_i386_debian_6_0 shows this warning: CCmigration.o migration.c: In function

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-09-29 Thread Michael Tokarev
29.09.2013 19:41, Stefan Weil wrote: The QEMU buildbot default_i386_debian_6_0 shows this warning: CCmigration.o migration.c: In function 'qmp_query_migrate_capabilities': migration.c:149: warning: 'caps' may be used uninitialized in this function Gah, how disgusting. The code is

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-09-29 Thread Stefan Weil
Am 29.09.2013 22:13, schrieb Michael Tokarev: 29.09.2013 19:41, Stefan Weil wrote: The QEMU buildbot default_i386_debian_6_0 shows this warning: CCmigration.o migration.c: In function 'qmp_query_migrate_capabilities': migration.c:149: warning: 'caps' may be used uninitialized in