Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp: reorder include to fix FreeBSD build failure

2013-07-17 Thread Jan Kiszka
On 2013-07-14 00:35, Ed Maste wrote: On 13 July 2013 05:12, Michael Tokarev m...@tls.msk.rumailto:m...@tls.msk.ru wrote: Remaining: struct mbuf { union M_dat { charm_dat_[1]; /* ANSI don't like 0 sized arrays */ char*m_ext_; }

Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp: reorder include to fix FreeBSD build failure

2013-07-17 Thread Michael Tokarev
17.07.2013 12:32, Jan Kiszka wrote: No problem, as Peter already said. Please provide an according patch. http://thread.gmane.org/gmane.comp.emulators.qemu/221949/focus=221975 (an attachtment there) http://git.corpit.ru/?p=qemu.git;a=commitdiff;h=2915c3b20260b1a653fced3b584d0c2b012880dc

Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp: reorder include to fix FreeBSD build failure

2013-07-17 Thread Ed Maste
On 17 July 2013 04:54, Michael Tokarev m...@tls.msk.ru wrote: 17.07.2013 12:32, Jan Kiszka wrote: No problem, as Peter already said. Please provide an according patch. http://thread.gmane.org/gmane.comp.emulators.qemu/221949/focus=221975 (an attachtment there)

Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp: reorder include to fix FreeBSD build failure

2013-07-14 Thread Peter Maydell
On 13 July 2013 23:35, Ed Maste ema...@freebsd.org wrote: I'm not sure that anonymous union support is universal across all compilers used to build QEMU though - do you know? A quick grep shows we already use anonymous unions in a few places, so it must be OK. -- PMM

Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp: reorder include to fix FreeBSD build failure

2013-07-13 Thread Michael Tokarev
13.07.2013 00:29, Ed Maste wrote: Signed-off-by: Ed Maste ema...@freebsd.org --- The issue comes from slirp/mbuf.h #defining m_flags, which conflicts with a header included via semaphore.h on FreeBSD. Umgh. How.. disgusting... :( Here's the code in question. /* header at beginning of each

Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp: reorder include to fix FreeBSD build failure

2013-07-13 Thread Ed Maste
On 13 July 2013 05:12, Michael Tokarev m...@tls.msk.ru wrote: Remaining: struct mbuf { union M_dat { charm_dat_[1]; /* ANSI don't like 0 sized arrays */ char*m_ext_; } M_dat; }; #define m_dat M_dat.m_dat_ #define m_ext