Re: [Qemu-devel] [Qemu-trivial] [PATCH 23/34] hw/dma/i8257: rename DMA_init() to i8257_dma_init()

2017-10-06 Thread Eduardo Otubo"
On Fri, Sep 22, 2017 at 03:08:03PM -0300, Philippe Mathieu-Daudé wrote: > On 09/22/2017 02:43 PM, Hervé Poussineau wrote: > > Le 22/09/2017 à 18:01, Philippe Mathieu-Daudé a écrit : > [...] > > > +void i8257_dma_init(ISABus *bus, int high_page_enable); > > > + > > > > As you're changing the

Re: [Qemu-devel] [Qemu-trivial] [PATCH 23/34] hw/dma/i8257: rename DMA_init() to i8257_dma_init()

2017-09-22 Thread Philippe Mathieu-Daudé
On 09/22/2017 02:43 PM, Hervé Poussineau wrote: Le 22/09/2017 à 18:01, Philippe Mathieu-Daudé a écrit : [...] +void i8257_dma_init(ISABus *bus, int high_page_enable); + As you're changing the DMA_init prototype, can you add an Error **errp parameter, and pass _abort in each caller? See