Re: [Qemu-devel] [RFC] monitor: turn on Out-Of-Band by default again

2018-06-01 Thread Stefan Hajnoczi
On Thu, May 24, 2018 at 09:08:58AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Mon, May 21, 2018 at 09:13:06AM -0500, Eric Blake wrote: > >> On 05/21/2018 03:42 AM, Peter Xu wrote: > >> > We turned Out-Of-Band feature of monitors off for 2.12 release. Now we > >> > try to turn

Re: [Qemu-devel] [RFC] monitor: turn on Out-Of-Band by default again

2018-05-30 Thread Peter Xu
On Wed, May 30, 2018 at 04:04:58PM +0800, Peter Xu wrote: > On Tue, May 22, 2018 at 02:40:26PM -0400, John Snow wrote: > > > > > > On 05/21/2018 10:13 AM, Eric Blake wrote: > > > On 05/21/2018 03:42 AM, Peter Xu wrote: > > >> We turned Out-Of-Band feature of monitors off for 2.12 release.  Now

Re: [Qemu-devel] [RFC] monitor: turn on Out-Of-Band by default again

2018-05-30 Thread Peter Xu
On Tue, May 22, 2018 at 02:40:26PM -0400, John Snow wrote: > > > On 05/21/2018 10:13 AM, Eric Blake wrote: > > On 05/21/2018 03:42 AM, Peter Xu wrote: > >> We turned Out-Of-Band feature of monitors off for 2.12 release.  Now we > >> try to turn that on again. > > > > "try to turn" sounds weak,

Re: [Qemu-devel] [RFC] monitor: turn on Out-Of-Band by default again

2018-05-29 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Thu, May 24, 2018 at 09:08:58AM +0200, Markus Armbruster wrote: > > Peter Xu writes: > > > > > On Mon, May 21, 2018 at 09:13:06AM -0500, Eric Blake wrote: > > >> On 05/21/2018 03:42 AM, Peter Xu wrote: > > >> > We turned Out-Of-Band feature of monitors

Re: [Qemu-devel] [RFC] monitor: turn on Out-Of-Band by default again

2018-05-24 Thread Peter Xu
On Thu, May 24, 2018 at 09:08:58AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Mon, May 21, 2018 at 09:13:06AM -0500, Eric Blake wrote: > >> On 05/21/2018 03:42 AM, Peter Xu wrote: > >> > We turned Out-Of-Band feature of monitors off for 2.12 release. Now we >

Re: [Qemu-devel] [RFC] monitor: turn on Out-Of-Band by default again

2018-05-24 Thread Markus Armbruster
Peter Xu writes: > On Mon, May 21, 2018 at 09:13:06AM -0500, Eric Blake wrote: >> On 05/21/2018 03:42 AM, Peter Xu wrote: >> > We turned Out-Of-Band feature of monitors off for 2.12 release. Now we >> > try to turn that on again. >> >> "try to turn" sounds weak, like you

Re: [Qemu-devel] [RFC] monitor: turn on Out-Of-Band by default again

2018-05-22 Thread John Snow
On 05/21/2018 10:13 AM, Eric Blake wrote: > On 05/21/2018 03:42 AM, Peter Xu wrote: >> We turned Out-Of-Band feature of monitors off for 2.12 release.  Now we >> try to turn that on again. > > "try to turn" sounds weak, like you aren't sure of this patch.  If you > aren't sure, then why should

Re: [Qemu-devel] [RFC] monitor: turn on Out-Of-Band by default again

2018-05-21 Thread Peter Xu
On Mon, May 21, 2018 at 09:13:06AM -0500, Eric Blake wrote: > On 05/21/2018 03:42 AM, Peter Xu wrote: > > We turned Out-Of-Band feature of monitors off for 2.12 release. Now we > > try to turn that on again. > > "try to turn" sounds weak, like you aren't sure of this patch. If you > aren't

Re: [Qemu-devel] [RFC] monitor: turn on Out-Of-Band by default again

2018-05-21 Thread Eric Blake
On 05/21/2018 03:42 AM, Peter Xu wrote: We turned Out-Of-Band feature of monitors off for 2.12 release. Now we try to turn that on again. "try to turn" sounds weak, like you aren't sure of this patch. If you aren't sure, then why should we feel safe in applying it? This text is going in

Re: [Qemu-devel] [RFC] monitor: turn on Out-Of-Band by default again

2018-05-21 Thread Peter Xu
On Mon, May 21, 2018 at 09:59:07AM +0100, Daniel P. Berrangé wrote: > On Mon, May 21, 2018 at 04:42:49PM +0800, Peter Xu wrote: > > We turned Out-Of-Band feature of monitors off for 2.12 release. Now we > > try to turn that on again. > > > > Signed-off-by: Peter Xu > > -- > >

Re: [Qemu-devel] [RFC] monitor: turn on Out-Of-Band by default again

2018-05-21 Thread Daniel P . Berrangé
On Mon, May 21, 2018 at 04:42:49PM +0800, Peter Xu wrote: > We turned Out-Of-Band feature of monitors off for 2.12 release. Now we > try to turn that on again. > > Signed-off-by: Peter Xu > -- > Now OOB should be okay with all known tests (except iotest qcow2, since > it is

[Qemu-devel] [RFC] monitor: turn on Out-Of-Band by default again

2018-05-21 Thread Peter Xu
We turned Out-Of-Band feature of monitors off for 2.12 release. Now we try to turn that on again. Signed-off-by: Peter Xu -- Now OOB should be okay with all known tests (except iotest qcow2, since it is still broken on master), and AFAIK now we should also be okay with