Re: [Qemu-devel] [RFC 00/14] More patches to disable stuff

2018-07-19 Thread Cornelia Huck
On Thu, 19 Jul 2018 13:58:02 +0200 Thomas Huth wrote: > On 19.07.2018 13:45, Cornelia Huck wrote: > > On Thu, 19 Jul 2018 13:06:59 +0200 > > Thomas Huth wrote: > >> I agree with you that the current situation with virtio-pci. c is bad. I > >> think we should split it up into individual files in

Re: [Qemu-devel] [RFC 00/14] More patches to disable stuff

2018-07-19 Thread Thomas Huth
On 19.07.2018 13:45, Cornelia Huck wrote: > On Thu, 19 Jul 2018 13:06:59 +0200 > Thomas Huth wrote: > >> On 17.07.2018 19:00, Juan Quintela wrote: > >>> So far so good, but look at virtio-pci.c: >>> >>> static void virtio_rng_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp) >>> { >>>... >

Re: [Qemu-devel] [RFC 00/14] More patches to disable stuff

2018-07-19 Thread Cornelia Huck
On Thu, 19 Jul 2018 13:06:59 +0200 Thomas Huth wrote: > On 17.07.2018 19:00, Juan Quintela wrote: > > So far so good, but look at virtio-pci.c: > > > > static void virtio_rng_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp) > > { > >... > > } > > > > static void virtio_rng_pci_class_ini

Re: [Qemu-devel] [RFC 00/14] More patches to disable stuff

2018-07-19 Thread Thomas Huth
On 17.07.2018 19:00, Juan Quintela wrote: > Thomas Huth wrote: >> On 17.07.2018 14:04, Juan Quintela wrote: >>> Hi >>> >>> Notice that this is an RFC because they don't work. As said on my >>> previous submmision, we need -softmmu/config-devices.h to make >>> this work. This series just allow us

Re: [Qemu-devel] [RFC 00/14] More patches to disable stuff

2018-07-17 Thread Juan Quintela
Paolo Bonzini wrote: > On 17/07/2018 14:04, Juan Quintela wrote: >> Hi >> >> Notice that this is an RFC because they don't work. As said on my >> previous submmision, we need -softmmu/config-devices.h to make >> this work. This series just allow us to disable the devices, but not >> to enable i

Re: [Qemu-devel] [RFC 00/14] More patches to disable stuff

2018-07-17 Thread Juan Quintela
Thomas Huth wrote: > On 17.07.2018 14:04, Juan Quintela wrote: >> Hi >> >> Notice that this is an RFC because they don't work. As said on my >> previous submmision, we need -softmmu/config-devices.h to make >> this work. This series just allow us to disable the devices, but not >> to enable it

Re: [Qemu-devel] [RFC 00/14] More patches to disable stuff

2018-07-17 Thread Paolo Bonzini
On 17/07/2018 14:04, Juan Quintela wrote: > Hi > > Notice that this is an RFC because they don't work. As said on my > previous submmision, we need -softmmu/config-devices.h to make > this work. This series just allow us to disable the devices, but not > to enable it back O:-) > > Notice: > >

Re: [Qemu-devel] [RFC 00/14] More patches to disable stuff

2018-07-17 Thread Thomas Huth
On 17.07.2018 14:04, Juan Quintela wrote: > Hi > > Notice that this is an RFC because they don't work. As said on my > previous submmision, we need -softmmu/config-devices.h to make > this work. This series just allow us to disable the devices, but not > to enable it back O:-) > > Notice: > >

[Qemu-devel] [RFC 00/14] More patches to disable stuff

2018-07-17 Thread Juan Quintela
Hi Notice that this is an RFC because they don't work. As said on my previous submmision, we need -softmmu/config-devices.h to make this work. This series just allow us to disable the devices, but not to enable it back O:-) Notice: - scsi stuff: we are testing they in cdrom-test.c, so we need