Re: [Qemu-devel] [RFC 01/15] char-io: fix possible race on IOWatchPoll

2017-09-20 Thread Peter Xu
On Wed, Sep 20, 2017 at 12:29:21PM +0100, Daniel P. Berrange wrote: > On Wed, Sep 20, 2017 at 07:18:49PM +0800, Peter Xu wrote: > > On Wed, Sep 20, 2017 at 12:03:09PM +0100, Daniel P. Berrange wrote: > > > On Wed, Sep 20, 2017 at 06:49:58PM +0800, Peter Xu wrote: > > > > On Wed, Sep 20, 2017 at

Re: [Qemu-devel] [RFC 01/15] char-io: fix possible race on IOWatchPoll

2017-09-20 Thread Daniel P. Berrange
On Wed, Sep 20, 2017 at 05:09:26PM +0800, Peter Xu wrote: > On Wed, Sep 20, 2017 at 08:57:03AM +0100, Daniel P. Berrange wrote: > > On Thu, Sep 14, 2017 at 03:50:22PM +0800, Peter Xu wrote: > > > This is not a problem if we are only having one single loop thread like > > > before. However, after

Re: [Qemu-devel] [RFC 01/15] char-io: fix possible race on IOWatchPoll

2017-09-20 Thread Daniel P. Berrange
On Wed, Sep 20, 2017 at 07:18:49PM +0800, Peter Xu wrote: > On Wed, Sep 20, 2017 at 12:03:09PM +0100, Daniel P. Berrange wrote: > > On Wed, Sep 20, 2017 at 06:49:58PM +0800, Peter Xu wrote: > > > On Wed, Sep 20, 2017 at 10:14:38AM +0100, Daniel P. Berrange wrote: > > > > On Wed, Sep 20, 2017 at

Re: [Qemu-devel] [RFC 01/15] char-io: fix possible race on IOWatchPoll

2017-09-20 Thread Peter Xu
On Wed, Sep 20, 2017 at 08:57:03AM +0100, Daniel P. Berrange wrote: > On Thu, Sep 14, 2017 at 03:50:22PM +0800, Peter Xu wrote: > > This is not a problem if we are only having one single loop thread like > > before. However, after per-monitor thread is introduced, this is not > > true any more,

Re: [Qemu-devel] [RFC 01/15] char-io: fix possible race on IOWatchPoll

2017-09-20 Thread Peter Xu
On Wed, Sep 20, 2017 at 12:03:09PM +0100, Daniel P. Berrange wrote: > On Wed, Sep 20, 2017 at 06:49:58PM +0800, Peter Xu wrote: > > On Wed, Sep 20, 2017 at 10:14:38AM +0100, Daniel P. Berrange wrote: > > > On Wed, Sep 20, 2017 at 05:09:26PM +0800, Peter Xu wrote: > > > > On Wed, Sep 20, 2017 at

Re: [Qemu-devel] [RFC 01/15] char-io: fix possible race on IOWatchPoll

2017-09-20 Thread Daniel P. Berrange
On Wed, Sep 20, 2017 at 06:49:58PM +0800, Peter Xu wrote: > On Wed, Sep 20, 2017 at 10:14:38AM +0100, Daniel P. Berrange wrote: > > On Wed, Sep 20, 2017 at 05:09:26PM +0800, Peter Xu wrote: > > > On Wed, Sep 20, 2017 at 08:57:03AM +0100, Daniel P. Berrange wrote: > > > > On Thu, Sep 14, 2017 at

Re: [Qemu-devel] [RFC 01/15] char-io: fix possible race on IOWatchPoll

2017-09-20 Thread Peter Xu
On Wed, Sep 20, 2017 at 10:14:38AM +0100, Daniel P. Berrange wrote: > On Wed, Sep 20, 2017 at 05:09:26PM +0800, Peter Xu wrote: > > On Wed, Sep 20, 2017 at 08:57:03AM +0100, Daniel P. Berrange wrote: > > > On Thu, Sep 14, 2017 at 03:50:22PM +0800, Peter Xu wrote: > > > > This is not a problem if

Re: [Qemu-devel] [RFC 01/15] char-io: fix possible race on IOWatchPoll

2017-09-20 Thread Daniel P. Berrange
On Thu, Sep 14, 2017 at 03:50:22PM +0800, Peter Xu wrote: > This is not a problem if we are only having one single loop thread like > before. However, after per-monitor thread is introduced, this is not > true any more, and the race can happen. > > The race can be triggered with "make check -j8"

Re: [Qemu-devel] [RFC 01/15] char-io: fix possible race on IOWatchPoll

2017-09-19 Thread Peter Xu
On Tue, Sep 19, 2017 at 02:59:37PM -0500, Eric Blake wrote: > On 09/14/2017 02:50 AM, Peter Xu wrote: > > This is not a problem if we are only having one single loop thread like > > before. However, after per-monitor thread is introduced, this is not > > true any more, and the race can happen. >

Re: [Qemu-devel] [RFC 01/15] char-io: fix possible race on IOWatchPoll

2017-09-19 Thread Eric Blake
On 09/14/2017 02:50 AM, Peter Xu wrote: > This is not a problem if we are only having one single loop thread like > before. However, after per-monitor thread is introduced, this is not > true any more, and the race can happen. > > The race can be triggered with "make check -j8" sometimes: > >

[Qemu-devel] [RFC 01/15] char-io: fix possible race on IOWatchPoll

2017-09-14 Thread Peter Xu
This is not a problem if we are only having one single loop thread like before. However, after per-monitor thread is introduced, this is not true any more, and the race can happen. The race can be triggered with "make check -j8" sometimes: qemu-system-x86_64: