Re: [Qemu-devel] [RFC 03/29] io: fix qio_channel_socket_accept err handling

2017-08-01 Thread Peter Xu
On Tue, Aug 01, 2017 at 09:55:08AM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Tue, Aug 01, 2017 at 10:25:19AM +0800, Peter Xu wrote: > > > On Mon, Jul 31, 2017 at 05:53:39PM +0100, Dr. David Alan Gilbert wrote: > > > > * Peter Xu

Re: [Qemu-devel] [RFC 03/29] io: fix qio_channel_socket_accept err handling

2017-08-01 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Tue, Aug 01, 2017 at 10:25:19AM +0800, Peter Xu wrote: > > On Mon, Jul 31, 2017 at 05:53:39PM +0100, Dr. David Alan Gilbert wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > When accept failed, we should setup errp with the reason.

Re: [Qemu-devel] [RFC 03/29] io: fix qio_channel_socket_accept err handling

2017-08-01 Thread Daniel P. Berrange
On Tue, Aug 01, 2017 at 10:25:19AM +0800, Peter Xu wrote: > On Mon, Jul 31, 2017 at 05:53:39PM +0100, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > When accept failed, we should setup errp with the reason. More > > > importantly, the caller may assume errp be

Re: [Qemu-devel] [RFC 03/29] io: fix qio_channel_socket_accept err handling

2017-07-31 Thread Peter Xu
On Mon, Jul 31, 2017 at 05:53:39PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > When accept failed, we should setup errp with the reason. More > > importantly, the caller may assume errp be non-NULL when error happens, > > and not setting the errp may crash

Re: [Qemu-devel] [RFC 03/29] io: fix qio_channel_socket_accept err handling

2017-07-31 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > When accept failed, we should setup errp with the reason. More > importantly, the caller may assume errp be non-NULL when error happens, > and not setting the errp may crash QEMU. > > Signed-off-by: Peter Xu > --- > io/channel-socket.c

[Qemu-devel] [RFC 03/29] io: fix qio_channel_socket_accept err handling

2017-07-28 Thread Peter Xu
When accept failed, we should setup errp with the reason. More importantly, the caller may assume errp be non-NULL when error happens, and not setting the errp may crash QEMU. Signed-off-by: Peter Xu --- io/channel-socket.c | 1 + 1 file changed, 1 insertion(+) diff --git