Re: [Qemu-devel] [RFC 4/9] acpi: replace opencoded opcodes with defines

2014-02-16 Thread Michael S. Tsirkin
On Fri, Feb 07, 2014 at 01:51:31PM +0100, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com The reason I avoided doing this is that this conflicts with qemu coding style which only uses camel case for types. So as a minimum this needs a comment explaining that we are using

[Qemu-devel] [RFC 4/9] acpi: replace opencoded opcodes with defines

2014-02-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/i386/acpi-build.c | 28 ++-- 1 files changed, 18 insertions(+), 10 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 6a43a7d..1dbe5ce 100644 --- a/hw/i386/acpi-build.c +++