Re: [Qemu-devel] [RFC PATCH 01/10] vfio: Remove unneeded union from VFIOContainer

2015-09-23 Thread Thomas Huth
On 17/09/15 15:09, David Gibson wrote: > Currently the VFIOContainer iommu_data field contains a union with > different information for different host iommu types. However: >* It only actually contains information for the x86-like "Type1" iommu >* Because we have a common listener the

Re: [Qemu-devel] [RFC PATCH 01/10] vfio: Remove unneeded union from VFIOContainer

2015-09-23 Thread Laurent Vivier
On 17/09/2015 15:09, David Gibson wrote: > Currently the VFIOContainer iommu_data field contains a union with > different information for different host iommu types. However: >* It only actually contains information for the x86-like "Type1" iommu >* Because we have a common listener the

Re: [Qemu-devel] [RFC PATCH 01/10] vfio: Remove unneeded union from VFIOContainer

2015-09-23 Thread David Gibson
On Wed, Sep 23, 2015 at 12:31:25PM +0200, Thomas Huth wrote: > On 17/09/15 15:09, David Gibson wrote: > > Currently the VFIOContainer iommu_data field contains a union with > > different information for different host iommu types. However: > >* It only actually contains information for the

Re: [Qemu-devel] [RFC PATCH 01/10] vfio: Remove unneeded union from VFIOContainer

2015-09-18 Thread Alexey Kardashevskiy
On 09/17/2015 11:09 PM, David Gibson wrote: Currently the VFIOContainer iommu_data field contains a union with different information for different host iommu types. However: * It only actually contains information for the x86-like "Type1" iommu * Because we have a common listener the

[Qemu-devel] [RFC PATCH 01/10] vfio: Remove unneeded union from VFIOContainer

2015-09-17 Thread David Gibson
Currently the VFIOContainer iommu_data field contains a union with different information for different host iommu types. However: * It only actually contains information for the x86-like "Type1" iommu * Because we have a common listener the Type1 fields are actually used on all IOMMU types,