Re: [Qemu-devel] [RFC PATCH 09/11] Implement qdict_flatten()

2013-07-16 Thread Kevin Wolf
Am 11.07.2013 um 22:25 hat Eric Blake geschrieben: On 07/09/2013 03:53 AM, Kevin Wolf wrote: Worth repeating this comment from the code into the commit message? + * qdict_flatten(): For each nested QDict with key x, all fields with key y + * are moved to this QDict and their key is

Re: [Qemu-devel] [RFC PATCH 09/11] Implement qdict_flatten()

2013-07-11 Thread Eric Blake
On 07/09/2013 03:53 AM, Kevin Wolf wrote: Worth repeating this comment from the code into the commit message? + * qdict_flatten(): For each nested QDict with key x, all fields with key y + * are moved to this QDict and their key is renamed to x.y. Otherwise, I had to read nearly the entire

[Qemu-devel] [RFC PATCH 09/11] Implement qdict_flatten()

2013-07-09 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- include/qapi/qmp/qdict.h | 1 + qobject/qdict.c | 47 +++ 2 files changed, 48 insertions(+) diff --git a/include/qapi/qmp/qdict.h b/include/qapi/qmp/qdict.h index 685b2e3..b261570 100644 ---