Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2014-01-07 Thread Igor Mammedov
On Mon, 06 Jan 2014 21:53:50 -0800 H. Peter Anvin h...@zytor.com wrote: On 03/25/2013 01:56 PM, Eduardo Habkost wrote: It needs to be possible to fix bugs It is possible to fix them today: just write a compat function or add a global variable that is handled by cpu_x86_init(),

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2014-01-06 Thread H. Peter Anvin
On 03/25/2013 01:56 PM, Eduardo Habkost wrote: It needs to be possible to fix bugs It is possible to fix them today: just write a compat function or add a global variable that is handled by cpu_x86_init(), and call it from the pc-1.3 machine-type init function. See

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-28 Thread Aurelien Jarno
On Wed, Feb 27, 2013 at 06:12:32PM -0800, H. Peter Anvin wrote: From: H. Peter Anvin h...@zytor.com Add models for 486SX, and pre-CPUID versions of the 486 (DX SX). Change the model number for the standard 486DX to a model which actually had CPUID. Note: these models are fairly

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-28 Thread H. Peter Anvin
On 03/28/2013 12:15 PM, Aurelien Jarno wrote: This really looks like Linux kernel specific. I haven't been able to test on a real machine, but the documentation I have found suggest that without and x87 FPU, the FPU instructions are simply ignored. The common way to detect an FPU is

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-28 Thread H. Peter Anvin
On 03/28/2013 12:15 PM, Aurelien Jarno wrote: This really looks like Linux kernel specific. I haven't been able to test on a real machine, but the documentation I have found suggest that without and x87 FPU, the FPU instructions are simply ignored. The common way to detect an FPU is

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-28 Thread Rob Landley
On 03/28/2013 03:12:11 PM, H. Peter Anvin wrote: On 03/28/2013 12:15 PM, Aurelien Jarno wrote: This really looks like Linux kernel specific. I haven't been able to test on a real machine, but the documentation I have found suggest that without and x87 FPU, the FPU instructions are simply

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-28 Thread H. Peter Anvin
Qemu is absolutely horrid at modeling corner cases. Rob Landley r...@landley.net wrote: On 03/28/2013 03:12:11 PM, H. Peter Anvin wrote: On 03/28/2013 12:15 PM, Aurelien Jarno wrote: This really looks like Linux kernel specific. I haven't been able to test on a real machine, but the

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-25 Thread Paolo Bonzini
Il 24/03/2013 06:06, H. Peter Anvin ha scritto: Low priority ping on this patchset...? -hpa I think it fell through the cracks due to the RFC tag. Patches 1 and 2 look good, but Anthony does not apply TCG patches. CCing Blue and Aurelien. Paolo

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-25 Thread Andreas Färber
Am 24.03.2013 06:06, schrieb H. Peter Anvin: Low priority ping on this patchset...? You forgot to CC me on the CPU models... Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-25 Thread Andreas Färber
Am 28.02.2013 03:12, schrieb H. Peter Anvin: From: H. Peter Anvin h...@zytor.com Add models for 486SX, and pre-CPUID versions of the 486 (DX SX). Change the model number for the standard 486DX to a model which actually had CPUID. Note: these models are fairly vestigial, for example most

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-25 Thread Igor Mammedov
On Mon, 25 Mar 2013 10:39:36 +0100 Andreas Färber afaer...@suse.de wrote: Am 28.02.2013 03:12, schrieb H. Peter Anvin: From: H. Peter Anvin h...@zytor.com Add models for 486SX, and pre-CPUID versions of the 486 (DX SX). Change the model number for the standard 486DX to a model which

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-25 Thread H. Peter Anvin
On 03/25/2013 08:15 AM, Igor Mammedov wrote: Such changes have been rejected in the past (e.g., n270 Atom). I personally wouldn't object to 486 changes, but I guess it should rather be handled via Igor's CPU static properties that I have in my review queue: The .model value would be set to 8

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-25 Thread Eduardo Habkost
On Mon, Mar 25, 2013 at 04:15:15PM +0100, Igor Mammedov wrote: On Mon, 25 Mar 2013 10:39:36 +0100 Andreas Färber afaer...@suse.de wrote: Am 28.02.2013 03:12, schrieb H. Peter Anvin: From: H. Peter Anvin h...@zytor.com Add models for 486SX, and pre-CPUID versions of the 486 (DX

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-25 Thread Eduardo Habkost
On Mon, Mar 25, 2013 at 11:44:30AM -0700, H. Peter Anvin wrote: On 03/25/2013 08:15 AM, Igor Mammedov wrote: Such changes have been rejected in the past (e.g., n270 Atom). I personally wouldn't object to 486 changes, but I guess it should rather be handled via Igor's CPU static properties

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-25 Thread H. Peter Anvin
On 03/25/2013 12:05 PM, Eduardo Habkost wrote: On Mon, Mar 25, 2013 at 11:44:30AM -0700, H. Peter Anvin wrote: On 03/25/2013 08:15 AM, Igor Mammedov wrote: Such changes have been rejected in the past (e.g., n270 Atom). I personally wouldn't object to 486 changes, but I guess it should rather

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-25 Thread H. Peter Anvin
Now, all this said... if the only objection is the change of model number for 486 then I suggest just dropping that. -hpa

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-25 Thread Eduardo Habkost
On Mon, Mar 25, 2013 at 01:45:47PM -0700, H. Peter Anvin wrote: On 03/25/2013 12:05 PM, Eduardo Habkost wrote: On Mon, Mar 25, 2013 at 11:44:30AM -0700, H. Peter Anvin wrote: On 03/25/2013 08:15 AM, Igor Mammedov wrote: Such changes have been rejected in the past (e.g., n270 Atom). I

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-25 Thread H. Peter Anvin
On 03/25/2013 01:56 PM, Eduardo Habkost wrote: It needs to be possible to fix bugs It is possible to fix them today: just write a compat function or add a global variable that is handled by cpu_x86_init(), and call it from the pc-1.3 machine-type init function. See

Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-03-23 Thread H. Peter Anvin
Low priority ping on this patchset...? -hpa

[Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models

2013-02-27 Thread H. Peter Anvin
From: H. Peter Anvin h...@zytor.com Add models for 486SX, and pre-CPUID versions of the 486 (DX SX). Change the model number for the standard 486DX to a model which actually had CPUID. Note: these models are fairly vestigial, for example most of the FPU operations still work; only F*ST[CS]W