Re: [Qemu-devel] [RFC PATCH 1/4] add support for machine models to specify their migration format

2011-07-29 Thread Anthony Liguori
On 06/30/2011 10:46 AM, Paolo Bonzini wrote: We need to provide a new migration format, and not break migration in old machine models. So add a migration_format field to QEMUMachine. Signed-off-by: Paolo Bonzinipbonz...@redhat.com --- cpu-common.h |3 --- hw/boards.h |1 +

Re: [Qemu-devel] [RFC PATCH 1/4] add support for machine models to specify their migration format

2011-07-29 Thread Paolo Bonzini
On 07/29/2011 03:08 PM, Anthony Liguori wrote: Please avoid this gcc extension as it's relatively obscure. But in addition, why would use you 0 as the new format instead of QEMU_VM_FILE_VERSION + 1? 0 is the default. If a machine doesn't specify a format, it gets the newest one

Re: [Qemu-devel] [RFC PATCH 1/4] add support for machine models to specify their migration format

2011-07-01 Thread Paolo Bonzini
On 06/30/2011 08:11 PM, Michael S. Tsirkin wrote: Signed-off-by: Paolo Bonzinipbonz...@redhat.com Should not machine describe guest behaviour? It seems that a flag to the migrate/save command to control format would be better - this way the same machine can migrate to different formats. I

[Qemu-devel] [RFC PATCH 1/4] add support for machine models to specify their migration format

2011-06-30 Thread Paolo Bonzini
We need to provide a new migration format, and not break migration in old machine models. So add a migration_format field to QEMUMachine. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpu-common.h |3 --- hw/boards.h |1 + qemu-common.h |3 +++ savevm.c |7 +--

Re: [Qemu-devel] [RFC PATCH 1/4] add support for machine models to specify their migration format

2011-06-30 Thread Michael S. Tsirkin
On Thu, Jun 30, 2011 at 05:46:14PM +0200, Paolo Bonzini wrote: We need to provide a new migration format, and not break migration in old machine models. So add a migration_format field to QEMUMachine. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Should not machine describe guest