Re: [Qemu-devel] [RFC PATCH 10/10] cpus: reclaim allocated vCPU objects

2014-08-12 Thread Anshul Makkar
Hi Gu, Looks more likely logic ordering to me based on indexes. Don't spend time looking into it, let me look into it if I have done something wrong and fix it . Thanks Anshul Makkar On Mon, Aug 11, 2014 at 4:35 PM, Anshul Makkar anshul.mak...@profitbricks.com wrote: Hi Gu, These are APIC

Re: [Qemu-devel] [RFC PATCH 10/10] cpus: reclaim allocated vCPU objects

2014-08-11 Thread Anshul Makkar
Hi Gu, These are APIC IDs. Taking the example from the previous mail. Original cpus:0,1 maxcpus:6 (qemu) device_add qemu64-x86_64-cpu,apic-id=3,id=cpu3 (qemu) device_add qemu64-x86_64-cpu,apic-id=5,id=cpu5 cat /proc/cpuinfo shows processor 0 processor 1 processor 2 processor 3 instead of 3

Re: [Qemu-devel] [RFC PATCH 10/10] cpus: reclaim allocated vCPU objects

2014-08-07 Thread Anshul Makkar
Thanks Gu.. cpu-hotunplug is working fine in my tests. For cpu-hotplug, I get inconsistent result if I delete arbitrary cpu and not just the last one. for eg list of cpus: 1, 2 ,3 device_add cpu 4 device_add cpu 5 device_add cpu 6 device_del cpu 4 device_del cpu 6 now if I do device_add cpu6,

[Qemu-devel] [RFC PATCH 10/10] cpus: reclaim allocated vCPU objects

2014-08-06 Thread Gu Zheng
After ACPI get a signal to eject a vCPU, the vCPU must be removed from CPU list,before the vCPU really removed, then release the all related vCPU objects. But we do not close KVM vcpu fd, just record it into a list, in order to reuse it. Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com