Re: [Qemu-devel] [RFC PATCH 2/3] raw-posix: Convert Linux AIO submission to coroutines

2014-11-28 Thread Ming Lei
On 11/28/14, Markus Armbruster arm...@redhat.com wrote: Ming Lei ming@canonical.com writes: Hi Kevin, On Wed, Nov 26, 2014 at 10:46 PM, Kevin Wolf kw...@redhat.com wrote: This improves the performance of requests because an ACB doesn't need to be allocated on the heap any more. It also

Re: [Qemu-devel] [RFC PATCH 2/3] raw-posix: Convert Linux AIO submission to coroutines

2014-11-28 Thread Markus Armbruster
Ming Lei ming@canonical.com writes: On 11/28/14, Markus Armbruster arm...@redhat.com wrote: Ming Lei ming@canonical.com writes: Hi Kevin, On Wed, Nov 26, 2014 at 10:46 PM, Kevin Wolf kw...@redhat.com wrote: This improves the performance of requests because an ACB doesn't need to

Re: [Qemu-devel] [RFC PATCH 2/3] raw-posix: Convert Linux AIO submission to coroutines

2014-11-28 Thread Ming Lei
On 11/28/14, Markus Armbruster arm...@redhat.com wrote: Ming Lei ming@canonical.com writes: On 11/28/14, Markus Armbruster arm...@redhat.com wrote: Ming Lei ming@canonical.com writes: Hi Kevin, On Wed, Nov 26, 2014 at 10:46 PM, Kevin Wolf kw...@redhat.com wrote: This improves the

Re: [Qemu-devel] [RFC PATCH 2/3] raw-posix: Convert Linux AIO submission to coroutines

2014-11-28 Thread Paolo Bonzini
On 28/11/2014 03:59, Ming Lei wrote: Hi Kevin, On Wed, Nov 26, 2014 at 10:46 PM, Kevin Wolf kw...@redhat.com wrote: This improves the performance of requests because an ACB doesn't need to be allocated on the heap any more. It also makes the code nicer and smaller. I am not sure it is

Re: [Qemu-devel] [RFC PATCH 2/3] raw-posix: Convert Linux AIO submission to coroutines

2014-11-28 Thread Kevin Wolf
Am 28.11.2014 um 03:59 hat Ming Lei geschrieben: Hi Kevin, On Wed, Nov 26, 2014 at 10:46 PM, Kevin Wolf kw...@redhat.com wrote: This improves the performance of requests because an ACB doesn't need to be allocated on the heap any more. It also makes the code nicer and smaller. I am

Re: [Qemu-devel] [RFC PATCH 2/3] raw-posix: Convert Linux AIO submission to coroutines

2014-11-28 Thread Kevin Wolf
Am 27.11.2014 um 10:50 hat Peter Lieven geschrieben: On 26.11.2014 15:46, Kevin Wolf wrote: This improves the performance of requests because an ACB doesn't need to be allocated on the heap any more. It also makes the code nicer and smaller. As a side effect, the codepath taken by

Re: [Qemu-devel] [RFC PATCH 2/3] raw-posix: Convert Linux AIO submission to coroutines

2014-11-28 Thread Kevin Wolf
Am 28.11.2014 um 13:57 hat Kevin Wolf geschrieben: Am 27.11.2014 um 10:50 hat Peter Lieven geschrieben: On 26.11.2014 15:46, Kevin Wolf wrote: This improves the performance of requests because an ACB doesn't need to be allocated on the heap any more. It also makes the code nicer and

Re: [Qemu-devel] [RFC PATCH 2/3] raw-posix: Convert Linux AIO submission to coroutines

2014-11-27 Thread Peter Lieven
On 26.11.2014 15:46, Kevin Wolf wrote: This improves the performance of requests because an ACB doesn't need to be allocated on the heap any more. It also makes the code nicer and smaller. As a side effect, the codepath taken by aio=threads is changed to use paio_submit_co(). This doesn't

Re: [Qemu-devel] [RFC PATCH 2/3] raw-posix: Convert Linux AIO submission to coroutines

2014-11-27 Thread Ming Lei
Hi Kevin, On Wed, Nov 26, 2014 at 10:46 PM, Kevin Wolf kw...@redhat.com wrote: This improves the performance of requests because an ACB doesn't need to be allocated on the heap any more. It also makes the code nicer and smaller. I am not sure it is good way for linux aio optimization: - for

Re: [Qemu-devel] [RFC PATCH 2/3] raw-posix: Convert Linux AIO submission to coroutines

2014-11-27 Thread Markus Armbruster
Ming Lei ming@canonical.com writes: Hi Kevin, On Wed, Nov 26, 2014 at 10:46 PM, Kevin Wolf kw...@redhat.com wrote: This improves the performance of requests because an ACB doesn't need to be allocated on the heap any more. It also makes the code nicer and smaller. I am not sure it is

[Qemu-devel] [RFC PATCH 2/3] raw-posix: Convert Linux AIO submission to coroutines

2014-11-26 Thread Kevin Wolf
This improves the performance of requests because an ACB doesn't need to be allocated on the heap any more. It also makes the code nicer and smaller. As a side effect, the codepath taken by aio=threads is changed to use paio_submit_co(). This doesn't change the performance at this point. Results