Re: [Qemu-devel] [RFC PATCH v3 1/3] Converting tracetool.sh to tracetool.py

2012-01-12 Thread Stefan Hajnoczi
2012/1/10 Lluís Vilanova vilan...@ac.upc.edu: Harsh Prateek Bora writes: +class Event(object): +    def __init__(self, num, line): +        self.num = num +        self.args = get_args(line) +        self.arglist = self.args.split(',') +        self.name = get_name(line) +        self.argc

Re: [Qemu-devel] [RFC PATCH v3 1/3] Converting tracetool.sh to tracetool.py

2012-01-11 Thread Harsh Bora
On 01/11/2012 12:08 PM, Harsh Bora wrote: On 01/11/2012 04:21 AM, Lluís Vilanova wrote: Harsh Prateek Bora writes: Signed-off-by: Harsh Prateek Boraha...@linux.vnet.ibm.com --- Makefile.objs | 6 +- Makefile.target | 10 +- configure | 7 +- scripts/tracetool | 643

Re: [Qemu-devel] [RFC PATCH v3 1/3] Converting tracetool.sh to tracetool.py

2012-01-11 Thread Stefan Hajnoczi
On Wed, Jan 11, 2012 at 8:46 AM, Harsh Bora ha...@linux.vnet.ibm.com wrote: On 01/11/2012 12:08 PM, Harsh Bora wrote: On 01/11/2012 04:21 AM, Lluís Vilanova wrote: Harsh Prateek Bora writes: Signed-off-by: Harsh Prateek Boraha...@linux.vnet.ibm.com --- Makefile.objs | 6 +-

Re: [Qemu-devel] [RFC PATCH v3 1/3] Converting tracetool.sh to tracetool.py

2012-01-11 Thread Stefan Hajnoczi
On Tue, Jan 10, 2012 at 10:59 AM, Harsh Prateek Bora ha...@linux.vnet.ibm.com wrote: +# Generator that yields Event objects given a trace-events file object +def read_events(fobj): +    event_num = 0 +    for line in fobj: +        if not line.strip(): +            continue +        if

Re: [Qemu-devel] [RFC PATCH v3 1/3] Converting tracetool.sh to tracetool.py

2012-01-11 Thread Stefan Hajnoczi
On Wed, Jan 11, 2012 at 6:25 AM, Harsh Bora ha...@linux.vnet.ibm.com wrote: Also, please confirm, whether I should work on top for qemu.git or your tracing branch on repo.or.cz/stefanha.git ? Please use https://github.com/stefanha/qemu/tree/tracing. (I also just sent a patch to update the git

Re: [Qemu-devel] [RFC PATCH v3 1/3] Converting tracetool.sh to tracetool.py

2012-01-11 Thread Lluís Vilanova
Harsh Prateek Bora writes: Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com --- Makefile.objs|6 +- Makefile.target | 10 +- configure|7 +- scripts/tracetool| 643 -- scripts/tracetool.py

Re: [Qemu-devel] [RFC PATCH v3 1/3] Converting tracetool.sh to tracetool.py

2012-01-11 Thread Stefan Hajnoczi
2012/1/10 Lluís Vilanova vilan...@ac.upc.edu: Harsh Prateek Bora writes: Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com ---  Makefile.objs        |    6 +-  Makefile.target      |   10 +-  configure            |    7 +-  scripts/tracetool    |  643

Re: [Qemu-devel] [RFC PATCH v3 1/3] Converting tracetool.sh to tracetool.py

2012-01-11 Thread Lluís Vilanova
Harsh Prateek Bora writes: Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com --- Makefile.objs|6 +- Makefile.target | 10 +- configure|7 +- scripts/tracetool| 643 -- scripts/tracetool.py

Re: [Qemu-devel] [RFC PATCH v3 1/3] Converting tracetool.sh to tracetool.py

2012-01-11 Thread Stefan Hajnoczi
On Tue, Jan 10, 2012 at 10:59 AM, Harsh Prateek Bora ha...@linux.vnet.ibm.com wrote: diff --git a/scripts/tracetool.py b/scripts/tracetool.py new file mode 100755 index 000..6874f66 --- /dev/null +++ b/scripts/tracetool.py @@ -0,0 +1,585 @@ +#!/usr/bin/env python +# Python based

[Qemu-devel] [RFC PATCH v3 1/3] Converting tracetool.sh to tracetool.py

2012-01-10 Thread Harsh Prateek Bora
Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com --- Makefile.objs|6 +- Makefile.target | 10 +- configure|7 +- scripts/tracetool| 643 -- scripts/tracetool.py | 585

Re: [Qemu-devel] [RFC PATCH v3 1/3] Converting tracetool.sh to tracetool.py

2012-01-10 Thread Harsh Bora
Hi Stefan, Thanks for an early review, I shall address your comments in next version. Also, please confirm, whether I should work on top for qemu.git or your tracing branch on repo.or.cz/stefanha.git ? regards, Harsh On 01/10/2012 08:20 PM, Stefan Hajnoczi wrote: On Tue, Jan 10, 2012 at

Re: [Qemu-devel] [RFC PATCH v3 1/3] Converting tracetool.sh to tracetool.py

2012-01-10 Thread Harsh Bora
On 01/11/2012 04:21 AM, Lluís Vilanova wrote: Harsh Prateek Bora writes: Signed-off-by: Harsh Prateek Boraha...@linux.vnet.ibm.com --- Makefile.objs|6 +- Makefile.target | 10 +- configure|7 +- scripts/tracetool| 643