Re: [Qemu-devel] [RFC PATCH v4 02/20] memattrs: add debug attribute

2017-03-24 Thread Brijesh Singh
On 03/24/2017 10:36 AM, Stefan Hajnoczi wrote: I suggest something like this instead: /* Debug memory access for AMD SEV */ That way it's clear this "debug" flag has a very specific meaning in the context of memory encryption. Sure, will update comments. -Brijesh

Re: [Qemu-devel] [RFC PATCH v4 02/20] memattrs: add debug attribute

2017-03-24 Thread Stefan Hajnoczi
On Thu, Mar 23, 2017 at 01:14:17PM -0500, Brijesh Singh wrote: > Hi Stefan, > > > On 03/23/2017 06:29 AM, Stefan Hajnoczi wrote: > > On Wed, Mar 08, 2017 at 03:51:28PM -0500, Brijesh Singh wrote: > > > Add a new debug attribute, the attribute should be set when guest memory > > > accesses are per

Re: [Qemu-devel] [RFC PATCH v4 02/20] memattrs: add debug attribute

2017-03-23 Thread Brijesh Singh
Hi Stefan, On 03/23/2017 06:29 AM, Stefan Hajnoczi wrote: On Wed, Mar 08, 2017 at 03:51:28PM -0500, Brijesh Singh wrote: Add a new debug attribute, the attribute should be set when guest memory accesses are performed for debug purposes. The attribute will be used in SEV guest, where we need to

Re: [Qemu-devel] [RFC PATCH v4 02/20] memattrs: add debug attribute

2017-03-23 Thread Stefan Hajnoczi
On Wed, Mar 08, 2017 at 03:51:28PM -0500, Brijesh Singh wrote: > Add a new debug attribute, the attribute should be set when guest memory > accesses are performed for debug purposes. > The attribute will be used in SEV guest, where we need to distinguish normal > vs debug access to guest memory. In

[Qemu-devel] [RFC PATCH v4 02/20] memattrs: add debug attribute

2017-03-08 Thread Brijesh Singh
Add a new debug attribute, the attribute should be set when guest memory accesses are performed for debug purposes. The attribute will be used in SEV guest, where we need to distinguish normal vs debug access to guest memory. In debug mode, we need to use SEV commands to access the guest memory.