Re: [Qemu-devel] [RFC v2 02/11] cpus: pass CPUState to run_on_cpu helpers

2016-07-11 Thread Christian Borntraeger
On 07/11/2016 02:38 PM, Sergey Fedorov wrote: > On 11/07/16 15:36, Christian Borntraeger wrote: >> On 07/06/2016 11:14 PM, Sergey Fedorov wrote: >>> From: Alex Bennée >>> >>> CPUState is a fairly common pointer to pass to these helpers. This means >>> if you need other arguments for the async_run_

Re: [Qemu-devel] [RFC v2 02/11] cpus: pass CPUState to run_on_cpu helpers

2016-07-11 Thread Sergey Fedorov
On 11/07/16 15:36, Christian Borntraeger wrote: > On 07/06/2016 11:14 PM, Sergey Fedorov wrote: >> From: Alex Bennée >> >> CPUState is a fairly common pointer to pass to these helpers. This means >> if you need other arguments for the async_run_on_cpu case you end up >> having to do a g_malloc to

Re: [Qemu-devel] [RFC v2 02/11] cpus: pass CPUState to run_on_cpu helpers

2016-07-11 Thread Christian Borntraeger
On 07/06/2016 11:14 PM, Sergey Fedorov wrote: > From: Alex Bennée > > CPUState is a fairly common pointer to pass to these helpers. This means > if you need other arguments for the async_run_on_cpu case you end up > having to do a g_malloc to stuff additional data into the routine. For > the curr

Re: [Qemu-devel] [RFC v2 02/11] cpus: pass CPUState to run_on_cpu helpers

2016-07-06 Thread David Gibson
On Thu, Jul 07, 2016 at 12:14:54AM +0300, Sergey Fedorov wrote: > From: Alex Bennée > > CPUState is a fairly common pointer to pass to these helpers. This means > if you need other arguments for the async_run_on_cpu case you end up > having to do a g_malloc to stuff additional data into the routi

[Qemu-devel] [RFC v2 02/11] cpus: pass CPUState to run_on_cpu helpers

2016-07-06 Thread Sergey Fedorov
From: Alex Bennée CPUState is a fairly common pointer to pass to these helpers. This means if you need other arguments for the async_run_on_cpu case you end up having to do a g_malloc to stuff additional data into the routine. For the current users this isn't a massive deal but for MTTCG this get