Re: [Qemu-devel] [RFC v3 0/8] Fix QEMU crash during memory hotplug with vhost=on

2015-07-17 Thread Andrey Korolyov
This means that the issue is fixed elsewhere during rc, I am not promising to find a commit quickly, but I would elaborate as fast as possible in a spare time. Apologies again for messing things up a little. Unfortunately it looks like that the fix is quantative rather than qualitative - with

Re: [Qemu-devel] [RFC v3 0/8] Fix QEMU crash during memory hotplug with vhost=on

2015-07-16 Thread Andrey Korolyov
On Wed, Jul 15, 2015 at 7:46 PM, Andrey Korolyov and...@xdel.ru wrote: On Wed, Jul 15, 2015 at 7:08 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jul 15, 2015 at 06:26:03PM +0300, Andrey Korolyov wrote: On Wed, Jul 15, 2015 at 6:18 PM, Igor Mammedov imamm...@redhat.com wrote: On Thu,

Re: [Qemu-devel] [RFC v3 0/8] Fix QEMU crash during memory hotplug with vhost=on

2015-07-15 Thread Andrey Korolyov
On Wed, Jul 15, 2015 at 7:08 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jul 15, 2015 at 06:26:03PM +0300, Andrey Korolyov wrote: On Wed, Jul 15, 2015 at 6:18 PM, Igor Mammedov imamm...@redhat.com wrote: On Thu, 9 Jul 2015 20:04:35 +0300 Andrey Korolyov and...@xdel.ru wrote: On

Re: [Qemu-devel] [RFC v3 0/8] Fix QEMU crash during memory hotplug with vhost=on

2015-07-15 Thread Igor Mammedov
On Thu, 9 Jul 2015 20:04:35 +0300 Andrey Korolyov and...@xdel.ru wrote: On Wed, Jul 8, 2015 at 6:46 PM, Igor Mammedov imamm...@redhat.com wrote: On Wed, 8 Jul 2015 13:01:05 +0300 Michael S. Tsirkin m...@redhat.com wrote: [...] - this fixes qemu on current kernels, so it's a bugfix

Re: [Qemu-devel] [RFC v3 0/8] Fix QEMU crash during memory hotplug with vhost=on

2015-07-15 Thread Andrey Korolyov
On Wed, Jul 15, 2015 at 6:18 PM, Igor Mammedov imamm...@redhat.com wrote: On Thu, 9 Jul 2015 20:04:35 +0300 Andrey Korolyov and...@xdel.ru wrote: On Wed, Jul 8, 2015 at 6:46 PM, Igor Mammedov imamm...@redhat.com wrote: On Wed, 8 Jul 2015 13:01:05 +0300 Michael S. Tsirkin m...@redhat.com

Re: [Qemu-devel] [RFC v3 0/8] Fix QEMU crash during memory hotplug with vhost=on

2015-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2015 at 06:26:03PM +0300, Andrey Korolyov wrote: On Wed, Jul 15, 2015 at 6:18 PM, Igor Mammedov imamm...@redhat.com wrote: On Thu, 9 Jul 2015 20:04:35 +0300 Andrey Korolyov and...@xdel.ru wrote: On Wed, Jul 8, 2015 at 6:46 PM, Igor Mammedov imamm...@redhat.com wrote: On

Re: [Qemu-devel] [RFC v3 0/8] Fix QEMU crash during memory hotplug with vhost=on

2015-07-09 Thread Andrey Korolyov
On Wed, Jul 8, 2015 at 6:46 PM, Igor Mammedov imamm...@redhat.com wrote: On Wed, 8 Jul 2015 13:01:05 +0300 Michael S. Tsirkin m...@redhat.com wrote: [...] - this fixes qemu on current kernels, so it's a bugfix - this changes the semantics of memory hot unplug slightly so I think it's

Re: [Qemu-devel] [RFC v3 0/8] Fix QEMU crash during memory hotplug with vhost=on

2015-07-08 Thread Igor Mammedov
On Wed, 8 Jul 2015 13:01:05 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jul 08, 2015 at 11:46:40AM +0200, Igor Mammedov wrote: Changelog: v2-v3: * fixed(work-arouned) unmapping issues, now memory subsytem keeps track of HVA mapped regions and doesn't allow to

Re: [Qemu-devel] [RFC v3 0/8] Fix QEMU crash during memory hotplug with vhost=on

2015-07-08 Thread Michael S. Tsirkin
On Wed, Jul 08, 2015 at 01:41:16PM +0200, Igor Mammedov wrote: As additional issue: deleting backend doesn't actually frees memory since it's just mmap(NORESERVE) over allocated region. It's possible to do madvise(MADV_DONTNEED) on area but it doesn't guaranty that kernel will free memory.

Re: [Qemu-devel] [RFC v3 0/8] Fix QEMU crash during memory hotplug with vhost=on

2015-07-08 Thread Michael S. Tsirkin
On Wed, Jul 08, 2015 at 11:46:40AM +0200, Igor Mammedov wrote: Changelog: v2-v3: * fixed(work-arouned) unmapping issues, now memory subsytem keeps track of HVA mapped regions and doesn't allow to map a new region at address where previos has benn mapped until

[Qemu-devel] [RFC v3 0/8] Fix QEMU crash during memory hotplug with vhost=on

2015-07-08 Thread Igor Mammedov
Changelog: v2-v3: * fixed(work-arouned) unmapping issues, now memory subsytem keeps track of HVA mapped regions and doesn't allow to map a new region at address where previos has benn mapped until previous region is gone * fixed offset calculations in

Re: [Qemu-devel] [RFC v3 0/8] Fix QEMU crash during memory hotplug with vhost=on

2015-07-08 Thread Igor Mammedov
On Wed, 8 Jul 2015 13:01:05 +0300 Michael S. Tsirkin m...@redhat.com wrote: [...] - this fixes qemu on current kernels, so it's a bugfix - this changes the semantics of memory hot unplug slightly so I think it's important to merge in 2.4 before we release qemu with memory hot unplug,